Skip to content

[Swift4] Use thread safe manager dictionary (#8583)#8584

Open
marcotta wants to merge 1 commit intoswagger-api:masterfrom
marcotta:Issue-8583
Open

[Swift4] Use thread safe manager dictionary (#8583)#8584
marcotta wants to merge 1 commit intoswagger-api:masterfrom
marcotta:Issue-8583

Conversation

@marcotta
Copy link
Copy Markdown
Contributor

@marcotta marcotta commented Aug 16, 2018

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ x] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [ x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @ehyche @jgavris

Description of the PR

Client crashes due to concurrent access of managerStore dictionary.
Swift2 and Swift3 had been enhanced respectively with the following pull requests:
#3873 #5610

@jgavris
Copy link
Copy Markdown
Contributor

jgavris commented Aug 16, 2018

Nice to see this coming back!

@marcotta marcotta closed this Aug 21, 2018
@marcotta marcotta deleted the Issue-8583 branch August 21, 2018 12:25
@marcotta marcotta restored the Issue-8583 branch August 21, 2018 14:31
@marcotta marcotta reopened this Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants