[Java] Implemented support for Play! 2.5.x (java8) for retrofit2 client#6007
[Java] Implemented support for Play! 2.5.x (java8) for retrofit2 client#6007wing328 merged 8 commits intoswagger-api:masterfrom
Conversation
|
Are we going to pull a new option for each new version of Play ?! |
|
@lukoyanov I agree with @cbornet that we should avoid introducing another option for this case. For TypeScript Angular2, we recently introduced the option For your case, I would suggest renaming the option to If users need to use Play! (2.4.x), they can use the master. |
|
@lukoyanov if you need any help, just let me know. |
implemented version switch via playVersion config option
|
@wing328 Should I reopen this PR against 3.0 branch? |
|
@lukoyanov sorry I incorrectly closed it. Please still target current master for the change. 3.0.0 is mainly for supporting OpenAPI spec 3.0. |
|
@wing328 Fixed issues after merge. |
|
@lukoyanov Let me review tomorrow and merge accordingly (sorry too busy these days...) |
|
@lukoyanov I ran Please take a look when you've time. |
|
@wing328 sorry, fixed it. |
|
@lukoyanov np. I performed some tests and the result is good. Thanks for the enhancement. |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Support for Play! 2.5.x (java8) for retrofit2 client