Skip to content

[Java] Play24 fixes (error handling, adapter, dateLibrary switch)#6302

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
lukoyanov:retrofit2-play24-error-handling
Aug 15, 2017
Merged

[Java] Play24 fixes (error handling, adapter, dateLibrary switch)#6302
wing328 merged 1 commit intoswagger-api:masterfrom
lukoyanov:retrofit2-play24-error-handling

Conversation

@lukoyanov
Copy link
Copy Markdown
Contributor

@lukoyanov lukoyanov commented Aug 12, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master for non-breaking changes and 3.0.0 branch for breaking (non-backward compatible) changes.

Description of the PR

  • fixed error handling (now retrofit2.HttpException is thrown instead of RuntimeException on API error)
  • value adapter now supports both F.Promise<Model> and F.Promise<Response<Model>> in retrofit interface
  • switched dataLibrary to java8

…f RuntimeException on API error)

value adapter now supports both F.Promise<Model> and F.Promise<Response<Model>> in retrofit interface
switched dataLibrary to java8
@wing328 wing328 merged commit 936c586 into swagger-api:master Aug 15, 2017
@wing328 wing328 added this to the v2.3.0 milestone Aug 15, 2017
@lukoyanov lukoyanov deleted the retrofit2-play24-error-handling branch September 5, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants