Fix generate additionalProperties array type #6081#6082
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Jul 23, 2017
isman-usoh:patch-2
Merged
Fix generate additionalProperties array type #6081#6082wing328 merged 1 commit intoswagger-api:masterfrom isman-usoh:patch-2
wing328 merged 1 commit intoswagger-api:masterfrom
isman-usoh:patch-2
Conversation
Contributor
|
@isman-usoh thanks for the PR. |
Contributor
|
@isman-usoh I did a test and confirmed the fix works |
Contributor
|
Just reviewing my PR in #6109 and wondering if this change should be in the |
Contributor
|
That is actually preferred if possible but my change to put all common
things into the abstract hasn't. Been fixed to be merged yet
…On Tue, Jul 25, 2017, 4:01 AM Damien Pontifex ***@***.***> wrote:
Just reviewing my PR and wondering if this change should be in the
AbstractTypeScriptClientCodegen class if it's valid to all TypeScript?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6082 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMPLtSLdOpDeY5LFeQ5S3AGYJxyNlgeVks5sRaDSgaJpZM4OZbKP>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Fix generate additionalProperties array type #6081