[TypeScript] Codegen class rename for Angular and AngularJS to reflect naming guidelines#6109
[TypeScript] Codegen class rename for Angular and AngularJS to reflect naming guidelines#6109wing328 merged 3 commits intoswagger-api:masterfrom damienpontifex:angular-naming-conventions
Conversation
|
@damienpontifex thanks for the PR. |
|
@damienpontifex when you've time, I wonder if you can rebase this PR on the latest master to help resolve the merge conflicts. |
|
@wing328 done but build failures after rebase. Will have to spend a little longer resolving |
| io.swagger.codegen.languages.TypeScriptAngularClientCodegen | ||
| io.swagger.codegen.languages.TypeScriptAureliaClientCodegen | ||
| io.swagger.codegen.languages.TypeScriptAngularJsClientCodegen | ||
| >>>>>>> Rrename for angular and angularjs to reflect naming guidelines |
|
@wing328 I think that's fixed it all. I can squash the changes into one commit when/If merged. |
see http://angularjs.blogspot.com.au/2017/01/branding-guidelines-for-angular-and.html - move makes typescript-angular -> typescript-angularjs - move makes typescript-angular2 -> typescript-angular Language string with generate was already this so generation shouldnt change but class naming follows this convention now
|
@wing328 any further thoughts/feedback on this? |
|
@damienpontifex last time I checked, this PR is good to merge but I want to merge #6130 first |
|
#6310 has been merged into master. Will merge this one over the weekend. |
|
@damienpontifex thanks for the PR, which has been merged into master. I've made the following minor changes: d8fceda - update TS Angular-related Windows batch files |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for breaking (non-backward compatible) changes.Description of the PR
see http://angularjs.blogspot.com.au/2017/01/branding-guidelines-for-angular-and.html for reason for naming change.
Previously TypescriptAngular referred to AngularJS and TypescriptAngular2 referred to Angular. This changes makes it clearer by using the names TypescriptAngularJs and TypescriptAngular to refer to AngularJS (1.x) and Angular (>2.x)
Generator language flag was already following this convention so usage shouldn't change but class naming follows this convention now.