[Typescript][Angular] fix regression/bug that parameters with an _ ignore naming convention#7313
[Typescript][Angular] fix regression/bug that parameters with an _ ignore naming convention#7313wing328 merged 1 commit intoswagger-api:masterfrom StingrayDigital:fix-7262
Conversation
…that camelCase naming was forced only in this part of the code when everywhere else it is configurable.
|
The issue I see with this change is it essentially reverts to the original functionality before a63e3f1 (it would simply use the loop instead of the original regex method). This would just cause the issue I was attempting to fix. As described in my response to issue #7262, it seems we need to change this code to be compatible with the My change is compatible when the option is not set (defaults to Pinging @wing328, since he merged my changes initially and is active on every mention of this option I can find. ;P I imagine he'll have a better notion of how we're supposed to be supporting this, since I didn't even know it existed before now. Lol. |
|
@defmonk0 My change is compatible with the naming option since it uses By calling this, it will check what is the prefered naming convention and replace the param name by the good naming in the path. |
|
@JFCote Holy crap, I completely missed that function call nested inside the With that there, yes, I agree, this should work perfectly well. Looks fine to me. |
wing328
changed the title
* master: (26 commits) [Scala] Fix async helper methods when body is optional (swagger-api#7274) [Rust] Recommend style based on 'rustfmt' defaults (swagger-api#7335) [Java:vertx] Initialize router in init method and re-use router member to create S… (swagger-api#7234) [Scala] Fix missing json4s import (swagger-api#7271) deploy snapshot version 2.3.1 [Ada] Add Ada support for server code generator swagger-api#6680 (swagger-api#7256) add shijinkui to scala technical committee Generate swagger yaml for go client (swagger-api#7281) use openjdk7 in travis to ensure it works with jdk7 docs(readme): update link to contributing guid (swagger-api#7332) Fix a regression bug that was introduce in a recent commit. Removed the tabs that were causing error in Play Framework (swagger-api#7241) Fix issue swagger-api#7262 with the parameter name in the path. The problem was that camelCase naming was forced only in this part of the code when everywhere else it is configurable. (swagger-api#7313) Java8 fix (swagger-api#7260) update to 2.3.1-SNAPSHOT fix typo, update 2017 to 2018 [Doc] add huawei cloud to companies list swagger-api#7308 (swagger-api#7309) Adding Peatio opensource as reference project (swagger-api#7267) Update README.md (swagger-api#7298) Update README.md (swagger-api#7299) [all] sys props in CodegenConstants ...
3 participants
The problem was that camelCase naming was forced only in this part of the code when everywhere else it is configurable.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09)
Description of the PR
Fix issue #7262
This bug seems to have been introduced by this commit: a63e3f1
So I'm tagging its author for review: @defmonk0
In summary, I've made sure that the parameters names in the path received the same treatment everywhere else instead of applying a camelCase by default.