[Java Play Framework] Fix a regression bug that was introduced in a recent commit in routes#7241
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Jan 7, 2018
StingrayDigital:java-playframework-fix-route-file-regression
Merged
[Java Play Framework] Fix a regression bug that was introduced in a recent commit in routes#7241wing328 merged 1 commit intoswagger-api:masterfrom StingrayDigital:java-playframework-fix-route-file-regression
wing328 merged 1 commit intoswagger-api:masterfrom
StingrayDigital:java-playframework-fix-route-file-regression
Conversation
…he tabs that were causing error in Play Framework
lukoyanov
approved these changes
Dec 21, 2017
Contributor
Author
|
@wing328 Why is this in the v2.4.0 milestone? It must be merged in the 2.3.0 because right now the generator is useless (it doesn't compile) |
Contributor
|
@JFCote sure. I will merge it and change the milestone to 2.3.1
I thought we'd integration tests (CircleCI) to make sure the auto-generated Play code compiles. |
Contributor
Author
|
@wing328 Maybe it's because the only sample that doesn't work is the "fake endpoint" one and for a long time it was not in the CI because it didn't compile at all. Could you please add this sample (and any other samples for the play framework) in the CircleCI? Thanks |
Contributor
|
@JFCote Sure. I'll check again and let you know if I need help fixing anything. |
4 tasks
jimschubert
added a commit
to jimschubert/swagger-codegen
that referenced
this pull request
Jan 10, 2018
* master: (26 commits) [Scala] Fix async helper methods when body is optional (swagger-api#7274) [Rust] Recommend style based on 'rustfmt' defaults (swagger-api#7335) [Java:vertx] Initialize router in init method and re-use router member to create S… (swagger-api#7234) [Scala] Fix missing json4s import (swagger-api#7271) deploy snapshot version 2.3.1 [Ada] Add Ada support for server code generator swagger-api#6680 (swagger-api#7256) add shijinkui to scala technical committee Generate swagger yaml for go client (swagger-api#7281) use openjdk7 in travis to ensure it works with jdk7 docs(readme): update link to contributing guid (swagger-api#7332) Fix a regression bug that was introduce in a recent commit. Removed the tabs that were causing error in Play Framework (swagger-api#7241) Fix issue swagger-api#7262 with the parameter name in the path. The problem was that camelCase naming was forced only in this part of the code when everywhere else it is configurable. (swagger-api#7313) Java8 fix (swagger-api#7260) update to 2.3.1-SNAPSHOT fix typo, update 2017 to 2018 [Doc] add huawei cloud to companies list swagger-api#7308 (swagger-api#7309) Adding Peatio opensource as reference project (swagger-api#7267) Update README.md (swagger-api#7298) Update README.md (swagger-api#7299) [all] sys props in CodegenConstants ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indentations were added in the route files which prevent Play Framework compilation
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09)
Description of the PR
Rollback the template file for routes which prevented the Play Framework from compiling.