Skip to content

[Java][Play] The apiPackage option was ignored#7316

Merged
wing328 merged 3 commits intoswagger-api:2.4.0from
StingrayDigital:fix-6867
Jan 10, 2018
Merged

[Java][Play] The apiPackage option was ignored#7316
wing328 merged 3 commits intoswagger-api:2.4.0from
StingrayDigital:fix-6867

Conversation

@JFCote
Copy link
Copy Markdown
Contributor

@JFCote JFCote commented Jan 4, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09)

Description of the PR

Fix for issue #6867 . The apiPackage is now taken care of.

@wing328 Please notice that to be able to test everything, I had to "redo" the fix done in this PR in the route file: #7241
Since the change is identical, it should merge perfectly but let me know if you have any problem.

@wing328 wing328 added this to the v2.4.0 milestone Jan 7, 2018
@wing328 wing328 changed the base branch from master to 2.4.0 January 7, 2018 03:18
@wing328 wing328 closed this Jan 9, 2018
@wing328 wing328 reopened this Jan 9, 2018
@JFCote
Copy link
Copy Markdown
Contributor Author

JFCote commented Jan 9, 2018

Why is this re-opened? @wing328

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Jan 10, 2018

@JFCote to retrigger the CI tests (Travis test wasn't even run, probably due to an issue in their end)

@wing328 wing328 merged commit ebf4efe into swagger-api:2.4.0 Jan 10, 2018
@wing328 wing328 changed the title Fix issue #6867 : The apiPackage option was ignored [Java][Play] The apiPackage option was ignored Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants