[Java][Play] The apiPackage option was ignored#7316
Merged
wing328 merged 3 commits intoswagger-api:2.4.0from Jan 10, 2018
StingrayDigital:fix-6867
Merged
[Java][Play] The apiPackage option was ignored#7316wing328 merged 3 commits intoswagger-api:2.4.0from StingrayDigital:fix-6867
wing328 merged 3 commits intoswagger-api:2.4.0from
StingrayDigital:fix-6867
Conversation
…r Java Play Framework.
Contributor
Author
|
Why is this re-opened? @wing328 |
Contributor
|
@JFCote to retrigger the CI tests (Travis test wasn't even run, probably due to an issue in their end) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09)
Description of the PR
Fix for issue #6867 . The
apiPackageis now taken care of.@wing328 Please notice that to be able to test everything, I had to "redo" the fix done in this PR in the route file: #7241
Since the change is identical, it should merge perfectly but let me know if you have any problem.