When qualifying Clang types with a module, make sure we choose a visible module #32465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinboehme
force-pushed
the
module-issue-fix
branch
from
78fe945 to
57978df
Compare
This comment has been minimized.
This comment has been minimized.
gribozavr
reviewed
Jun 19, 2020
gribozavr
reviewed
Jun 19, 2020
gribozavr
reviewed
Jun 19, 2020
gribozavr
reviewed
Jun 19, 2020
gribozavr
reviewed
Jun 19, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@swift-ci Please test |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@gribozavr I've now addressed all of your review comments. |
Contributor
|
@nkcsgexi, could you take a look at this PR? |
xymus
approved these changes
Jul 14, 2020
Contributor
xymus
left a comment
xymus
left a comment
There was a problem hiding this comment.
LGTM! Sorry for the delay.
Member
Contributor
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
…ng a C struct in different modules. The newly added test fails.
module. Clang types need special treatment because multiple Clang modules can contain the same type declarations from a textually included header, but not all of these modules may be visible. This fixes https://bugs.swift.org/browse/SR-13032
Putting the test in a separate directory makes it clearer that all of the input files are related and create a particular test case interaction.
…odules. Also, make sure we only process a module once.
hlopko
force-pushed
the
module-issue-fix
branch
from
7543c52 to
9973f62
Compare
Contributor
|
@swift-ci please test |
Contributor
|
I believe this PR is now good to go, all comments are addressed and we have 2 approvals already, so unless anybody comments, we will merge it tomorrow. |
Contributor
|
@swift-ci please test |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Dec 11, 2020
* 'main' of github.com:apple/swift: When qualifying Clang types with a module, make sure we choose a visible module (swiftlang#32465)
AnthonyLatsis
added
c interop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang types need special treatment because multiple Clang modules can contain the same type declarations from a textually included header, but not all of these modules may be visible.
Fixes #55477
The newly added test breaks without this fix.