[Threading][UnitTests] Don't use threads in the unit test in no-threads mode. #59403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This should fix the failure we saw in #59365 |
…ds mode. If the threading package is set to "none", don't actually use threads in the unit tests. rdar://95011060
al45tair
force-pushed
the
eng/PR-95011060
branch
from
db312c4 to
cdb2418
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
preset=buildbot_incremental_linux_crosscompile_wasm |
Member
Hmm, should we keep the behavior |
Contributor
Author
|
I think we should skip those tests. It seems pointless tracking the fact that we've "locked" a lock in an un-threaded environment. Looks like I also need to turn off the ExclusiveAccess tests when threading is set to none. |
Contributor
Author
|
Closed in favour of #59561 (which also disables a few tests for the threading=none case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the threading package is set to "none", don't actually use threads in the unit tests.
rdar://95011060