Skip to content

[Threading][test] Repair none threading tests #59561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
al45tair merged 3 commits into from
Jul 7, 2022
Merged

[Threading][test] Repair none threading tests #59561

al45tair merged 3 commits into from
Jul 7, 2022

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jun 18, 2022 •
edited
Loading

This fixes the all tests on no-thread based on #59403

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jun 18, 2022

@swift-ci Please smoke test

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jun 18, 2022

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun kateinoigakukun force-pushed the katei/repair-none-threading-tests branch from 50ed98a to b0001a9 Compare June 18, 2022 13:53
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jun 18, 2022

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jun 18, 2022

@swift-ci Please smoke test

@kateinoigakukun kateinoigakukun requested a review from al45tair June 18, 2022 22:08
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jun 20, 2022

@al45tair Kindly ping :)

al45tair
al45tair reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks fine, though I'm not sure we should remove the threading_package_default line in test/CMakeLists.txt. We should be passing the threading package name that we expect to use through to lit.

@kateinoigakukun kateinoigakukun force-pushed the katei/repair-none-threading-tests branch from b0001a9 to cb5a1a3 Compare June 20, 2022 13:24
@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Jun 23, 2022

@swift-ci please smoke test

@kateinoigakukun kateinoigakukun force-pushed the katei/repair-none-threading-tests branch from cb5a1a3 to 356156d Compare July 7, 2022 02:01
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jul 7, 2022

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jul 7, 2022

@swift-ci Please smoke test

@kateinoigakukun kateinoigakukun force-pushed the katei/repair-none-threading-tests branch 2 times, most recently from 249d08b to 356156d Compare July 7, 2022 02:48
@kateinoigakukun kateinoigakukun requested a review from al45tair July 7, 2022 08:59
@al45tair al45tair merged commit 9ea7cd4 into swiftlang:main Jul 7, 2022
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jul 7, 2022

Thank you for quick review 😄

@kateinoigakukun kateinoigakukun deleted the katei/repair-none-threading-tests branch July 7, 2022 09:02
@al45tair al45tair mentioned this pull request Jul 7, 2022
Closed
@al45tair
Copy link
Contributor

al45tair commented Jul 7, 2022

😊 Thank-you for working on this — and I'm glad the threading package stuff is useful for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@al45tair al45tair al45tair approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kateinoigakukun @MaxDesiatov @al45tair