Skip to content

[5.9] always use the argNames constructor for macro DeclNames #66500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuietMisdreavus merged 3 commits into from
Jun 13, 2023
Merged

[5.9] always use the argNames constructor for macro DeclNames #66500

QuietMisdreavus merged 3 commits into from
Jun 13, 2023

Conversation

@QuietMisdreavus
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus commented Jun 9, 2023

Cherry-pick of #66497

  • Explanation: Macros with no parameters have an inconsistent DeclName based on whether they were loaded from source code or a built-module.
  • Scope: Affects symbol graphs (and Swift-DocC documentation) for these macros.
  • Issue: rdar://110179186
  • Risk: Low. The deserialization logic that was removed was identical to the one that was left in its place, with the exception of which DeclName constructor is being used.
  • Testing: A test has been added to ensure that a parameterless macro has the same name regardless of whether it's loaded from source code or a built module.
  • Reviewer: @DougGregor

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner June 9, 2023 16:38
@QuietMisdreavus
Copy link
Contributor Author

QuietMisdreavus commented Jun 9, 2023

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

QuietMisdreavus commented Jun 12, 2023

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus force-pushed the QuietMisdreavus/5.9/parameterless-macros branch from a219a1d to b1f029d Compare June 12, 2023 20:54
@QuietMisdreavus
Copy link
Contributor Author

QuietMisdreavus commented Jun 12, 2023

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit b50e046 into release/5.9 Jun 13, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/parameterless-macros branch June 13, 2023 16:15
@amartini51 amartini51 mentioned this pull request Jul 22, 2023
Merged
amartini51 added a commit to swiftlang/swift-book that referenced this pull request Jul 24, 2023
@amartini51
Include trailing () in macro URLs. (#160)
e56627d 
This change matches an upstream change in the publication pipeline
that will start including the `()` at the end of macro's names:

    swiftlang/swift#66500

See also commit f2828dd,
where TSPL started linking to these macros.

Fixes: rdar://112501547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuietMisdreavus @DougGregor