Skip to content

utils: build Foundation macros for distribution #75869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
compnerd merged 2 commits into from
Aug 15, 2024
Merged

utils: build Foundation macros for distribution #75869

compnerd merged 2 commits into from
Aug 15, 2024

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Aug 13, 2024

This adds a build of the Foundation macros for distribution in the toolchain.

@compnerd
utils: build Foundation macros for distribution
dcdb9b1 
This adds a build of the Foundation macros for distribution in the
toolchain.
@compnerd compnerd requested a review from a team as a code owner August 13, 2024 21:42
@compnerd
Copy link
Member Author

compnerd commented Aug 13, 2024

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Aug 14, 2024

Please test with following PRs:
swiftlang/swift-foundation#849

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Aug 15, 2024

Please test with following PRs:
swiftlang/swift-foundation#849

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Aug 15, 2024

Please test with following PRs:
swiftlang/swift-foundation#849

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Aug 15, 2024 •
edited
Loading

Explanation: Build changes necessary to support building macros for Windows.
Scope: Enables building and distributing the Foundation macros on all platforms.
Issue:
Original PR: #75785, #75816
Risk: We would need additional changes to build and distribute the macros.
Testing: The original changes were tested as part of building the toolchain and the installer for Windows as well as the built image for Linux.
Reviewer: @jmschonfeld @etcwilde

@compnerd
Copy link
Member Author

compnerd commented Aug 15, 2024

Please test with following PRs:
swiftlang/swift-foundation#849

swiftlang/swift-installer-scripts#330

@swift-ci please build toolchain Windows platform

@compnerd compnerd merged commit ccb1dc5 into swiftlang:release/6.0 Aug 15, 2024
@compnerd compnerd deleted the 60foundations branch August 15, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@compnerd @stephentyrone @jmschonfeld