SwiftShims: memcmp should accept optional pointers on Darwin #77964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darwin defines memcmp with optional pointers. Update SwiftShims to define it to the same type to avoid deserialization failures where we get one over the other and the types don't match anymore. rdar://140596571
Contributor
Author
|
@swift-ci Please smoke test |
compnerd
approved these changes
Dec 4, 2024
Contributor
Author
|
@swift-ci Please smoke test Windows |
Contributor
Author
|
@swift-ci Please smoke test Linux |
2 similar comments
Contributor
Author
|
@swift-ci Please smoke test Linux |
Contributor
Author
|
@swift-ci Please smoke test Linux |
xymus
added a commit
to xymus/swift
that referenced
this pull request
Feb 13, 2025
Fix the SwiftShims local declaration of memcmp for its parameters to have the same optionality as the SDK version. They should be `_Nonnull` to mirror the `_string` version. Follow-up to swiftlang#77964 rdar://140596571
xymus
added a commit
to xymus/swift
that referenced
this pull request
Sep 11, 2025
Fix the SwiftShims local declaration of `memcmp` for its parameters to have the same optionality as the SDK version. They should be `_Nonnull` to mirror the `_string` version. Follow-up to swiftlang#77964 which wasn't quite right. rdar://140596571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darwin defines
memcmpwith optional pointers. Update SwiftShims to define it to the same type to avoid deserialization failures where we get one over the other and the types don't match.This basically brings back #36666 which changes were lost a little while back apparently.
rdar://140596571