SwiftShims: memcmp parameters should be _Nonnull on Apple platforms
#84246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the SwiftShims local declaration of `memcmp` for its parameters to have the same optionality as the SDK version. They should be `_Nonnull` to mirror the `_string` version. Follow-up to swiftlang#77964 which wasn't quite right. rdar://140596571
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
It looks like the last version was right on macOS after all. There may be another configuration difference that I'm missing. |
Contributor
Author
|
Closing, we need something more specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
SwiftShimslocal declaration ofmemcmpfor its parameters to have the same optionality as the SDK version. They should be_Nonnullto mirror the_stringversion. This helps the compiler using both theSwiftShimsand SDK versions interchangeably which avoids compiler crashes.Follow-up to #77964 which wasn't quite right.
rdar://140596571