[wasm] Add support for __builtin_va_list type mapping #84029
Merged
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cover all va_list family of types just aliased by __builtin_va_list, including __isoc_va_list from wasi-libc. This enables proper C interop for variable argument functions on WASI targets.
kateinoigakukun
requested review from
a team,
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
Member
Author
|
@swift-ci smoke test |
kateinoigakukun
commented
Aug 30, 2025
| @@ -0,0 +1,18 @@ | |||
| // RUN: %swift-frontend -target wasm32-unknown-wasip1 -parse-stdlib -module-name Swift -I %S/Inputs/custom-modules -typecheck %s | |||
Member
Author
There was a problem hiding this comment.
Added a test that always checks with Wasm target because the alias issue happens only for targets where __builtin_va_list is defined as void * by Clang (TargetInfo::BuiltinVaListKind::VoidPtrBuiltinVaList).
Contributor
|
@kateinoigakukun Would you have a moment to cherry-pick it for 6.2 after this PR is merged? |
Member
Author
|
Yeap, I can do it if we want. |
Xazax-hun
approved these changes
Sep 2, 2025
MaxDesiatov
added
c interop
MaxDesiatov
pushed a commit
to MaxDesiatov/swift
that referenced
this pull request
Sep 2, 2025
Cover all va_list family of types just aliased by __builtin_va_list, including __isoc_va_list from wasi-libc. This enables proper C interop for variable argument functions on WASI targets. Close swiftlang#72398 # Conflicts: # test/ClangImporter/Inputs/custom-modules/module.modulemap
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Sep 17, 2025
This PR removes a workaround on WASI where we were avoiding a call to `withVaList()` because it miscompiled there. That problem was fixed by swiftlang/swift#84029 and cherry-picked to 6.2.
2 tasks
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Sep 17, 2025
This PR removes a workaround on WASI where we were avoiding a call to `withVaList()` because it miscompiled there. That problem was fixed by swiftlang/swift#84029. It was cherry-picked to 6.2, but does not appear to be fixed in 6.2 CI, so the change here only applies to 6.3 onward. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover all va_list family of types just aliased by __builtin_va_list, including __isoc_va_list from wasi-libc. This enables proper C interop for variable argument functions on WASI targets.
Close #72398