6.2: [wasm] Add support for __builtin_va_list type mapping #84054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cover all va_list family of types just aliased by __builtin_va_list, including __isoc_va_list from wasi-libc. This enables proper C interop for variable argument functions on WASI targets. Close swiftlang#72398 # Conflicts: # test/ClangImporter/Inputs/custom-modules/module.modulemap
Contributor
Author
|
@kateinoigakukun here's the cherry-pick, but I'm still investigating scope and risk of this one to determine if it can be considered for 6.2 |
MaxDesiatov
changed the title
Contributor
|
If this is merged, Swift Testing can adopt in 6.2, but our use case isn't high-priority so we can wait for 6.3. |
Contributor
Author
|
Doesn't seem like this could qualify for 6.2 at this point. |
Contributor
|
This branch now tracks 6.2.2 onward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Cherry-pick of #84029, merged as 3f96cef
Cover all va_list family of types just aliased by __builtin_va_list, including __isoc_va_list from wasi-libc. This enables proper C interop for variable argument functions on WASI targets.
Close #72398
Scope:
Risk:
Testing:
Issue:
Reviewer: @Xazax-hun