feat: complete `ckb4ibc-test` with embedded `forcerelay-ckb-sdk` by ashuralyk · Pull Request #305 · synapseweb3/forcerelay

ashuralyk · 2023-08-22T07:00:42Z

background:

the forcerelay-ckb-sdk has almost completed, so we can embed it into our ckb4ibc-test to automatically test the packet relaying between two ckb endpoints

change log:

remove the hard-code of *_type_args config values from test-framework crate
change the generation of client_id from type_args to type_hash for security concerns
complete the coding of packet test
debug relayer monitor and query_channel
debug generation of AckPacket transaction
fix a capacity calculation bug
rebase feat: IBC test framework support Axon #308 @jjyr and pass through the test case specific_test_only_for_ckb

p.s. integration-test -> ica-filter-test seems cannot be fixed until we merge Hermes v1.6.0, it seems has pre-packed nix package that only matches latest Hermes version, which would cause failure while using previous version of Hermes framework

ashuralyk · 2023-08-22T08:37:32Z

@jjyr I'm refactoring ckb4ibc-test framework, I'm afraid it has impact on your current work of testing Axon Endpoints, so please check this PR

ashuralyk · 2023-08-23T13:02:50Z

@Flouse I have completed the coding of packet test case embedded in ckb4ibc-test and successfully sent SendPacket transaction, but the next process was stuck due to the monitor logic of relayer I guess, so the next stage is to debug and make test case pass through, @blckngm could help me do this if you have your leisure time

ashuralyk · 2023-08-24T14:55:16Z

@blckngm packet cell has successfully searched on chain_a, but the next problem is in query_channel method, it accepted channel-1 which is not existed on chain_a

ashuralyk · 2023-08-27T03:56:54Z

@blckngm current issue is blocked when searching RecvPacket through SDK, please take a moment to look at it synapseweb3/forcerelay-ckb-sdk#7

ashuralyk · 2023-08-29T07:35:33Z

@blckngm after using the latest revision of forcerelay-ckb-sdk, the CI process has stuck in searching AckPacket cell on chain-a https://github.com/synapseweb3/forcerelay/actions/runs/6008594876/job/16296503004?pr=305, so please take a look at it

blckngm · 2023-08-29T09:07:02Z

It's still related to cursor usage. Use https://github.com/synapseweb3/forcerelay-ckb-sdk/tree/temp-fix-cursor for now.

ashuralyk · 2023-08-29T12:49:36Z

@blckngm @Flouse @jjyr I have already passed ckb4ibc-test CI test locally which contains packet relaying test in ckb <-> ckb case, I think it's ok to prepare a code review

ashuralyk · 2023-08-30T02:05:54Z

@jjyr please help me check it out, I got nothing from my failed CI and I found its processing list is different from yours, so have you done something on it in your PR ?

https://github.com/synapseweb3/forcerelay/actions/runs/6012440875/job/16329029412?pr=305

jjyr · 2023-08-30T16:11:08Z

+    rt.block_on(ckb::sighash::init_sighash_celldep(&rpc_client))
+        .unwrap();
+    let hash = send_transaction(&chain_a_url, send_packet_tx).unwrap();
+    println!(


A way to implement this test on ibc-test-framework is to call the contract from counterparty chain, and check the contract's state in the deployed chain.

We should implement a contract both in solidity and in CKB to do this test.

jjyr

LGTM.

We should merge #308 before this PR,
#308 upgrade the integration-test CI and the implement Axon <-> CKB channel tests, it can gurantee this PR do not break the CI.

Then we rebase this PR and rewrite the packet test.

ashuralyk · 2023-08-31T02:34:18Z

LGTM.

We should merge #308 before this PR, #308 upgrade the integration-test CI and the implement Axon <-> CKB channel tests, it can gurantee this PR do not break the CI.

Then we rebase this PR and rewrite the packet test.

what's your recommend on merging this PR? my opinion is to start a new branch and move essential changes of packet test into it from this PR, do you recommend just merging it exactly after rebasing?

…r ckb4ibc-test

…ts, the next is debugging the relayer monitor logic

Don't block when the counterparty client type is already known!

…hannel method

…se issue

…t transaction

…ten it through SDK

ashuralyk · 2023-09-03T08:46:02Z

@Flouse the next operation of coding to do in ibc-test is the following:

implement packet test within axon endpoints
implement packet test between axon and ckb endpoints
advanced implement packet test with sUDT for ckb endpoints

ashuralyk · 2023-09-05T14:17:22Z

@jjyr suggestions in comments are applied

ashuralyk requested review from Flouse, blckngm and jjyr August 22, 2023 07:00

ashuralyk commented Aug 23, 2023

View reviewed changes

Comment thread tools/ckb4ibc-test/src/tests/packet.rs Outdated

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch from 5e4fac9 to 7d549a6 Compare August 23, 2023 12:56

ashuralyk marked this pull request as ready for review August 23, 2023 13:04

ashuralyk mentioned this pull request Aug 23, 2023

feat: IBC test framework support Axon #308

Merged

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch from 366f08a to 94cf4ba Compare August 24, 2023 14:52

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch from a86cb96 to b145d40 Compare August 25, 2023 15:42

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch 2 times, most recently from eb21636 to 94a8cc5 Compare August 29, 2023 06:12

ashuralyk mentioned this pull request Aug 30, 2023

checklist on pushing Ckb endpoint from connection/channel to packet #265

Closed

4 tasks

jjyr reviewed Aug 30, 2023

View reviewed changes

Comment thread crates/relayer/src/chain/ckb4ibc/utils.rs Outdated

jjyr reviewed Aug 30, 2023

View reviewed changes

Comment thread tools/ckb4ibc-test/src/framework/utils/ckb.rs Outdated

jjyr reviewed Aug 30, 2023

View reviewed changes

Comment thread tools/ckb4ibc-test/src/framework/utils/ckb.rs Outdated

jjyr reviewed Aug 30, 2023

View reviewed changes

ashuralyk requested a review from jjyr August 31, 2023 02:42

liyukun added 3 commits September 3, 2023 10:20

feat: eliminate manually change type_args values in test-framework fo…

3ccc594

…r ckb4ibc-test

feat(wip): prepare packet test framework

26a1eeb

feat(wip): add send_packet event trigger in ckb4ibc-test packet test

1bcd389

liyukun and others added 10 commits September 3, 2023 10:27

feat(wip): complete the coding of packet test between two ckb endpoin…

4e6b662

…ts, the next is debugging the relayer monitor logic

fix: ckb4ibc monitor watch counterparty client type

5d50cd7

Don't block when the counterparty client type is already known!

feat(wip): successfully searched packet cell but get wrong in query_c…

8beb879

…hannel method

feat(wip): solve channel_id mismatch problem, current is protobuf par…

1f79765

…se issue

feat(wip): successfully received SendPacket and constructed RecvPacke…

401c1ea

…t transaction

feat(wip): successfully submit RecvPacket transaction, but cannot lis…

d9bd393

…ten it through SDK

feat(wip): almost complete packet test

a9797f9

feat: upgrade forcerelay-ckb-sdk and ibc-ckb-contracts

cfac97e

feat: fix a capacity bug and complete packet test

f8f743b

chore: update workflow and clarify script_search_mode

5bc38bb

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch from 61aca69 to ae57d4b Compare September 3, 2023 04:57

feat: rebase dev and pass packet test within ckb endpoints

3d534e0

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch from ae57d4b to 3d534e0 Compare September 3, 2023 08:32

chore: update integration.yaml

609e12a

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch from f266d88 to 609e12a Compare September 3, 2023 13:43

jjyr requested changes Sep 5, 2023

View reviewed changes

jjyr reviewed Sep 5, 2023

View reviewed changes

Comment thread tools/ibc-test/src/tests/mod.rs

jjyr reviewed Sep 5, 2023

View reviewed changes

Comment thread tools/ibc-test/src/tests/packet.rs

ashuralyk requested a review from jjyr September 5, 2023 12:20

chore: fix commented suggestion

e7cd6c0

ashuralyk force-pushed the feat/embeded-with-ckb-sdk branch from ff0ecb8 to e7cd6c0 Compare September 5, 2023 14:10

jjyr approved these changes Sep 6, 2023

View reviewed changes

blckngm approved these changes Sep 6, 2023

View reviewed changes

ashuralyk added this pull request to the merge queue Sep 6, 2023

Merged via the queue into dev with commit 2f9ecfe Sep 6, 2023

ashuralyk deleted the feat/embeded-with-ckb-sdk branch September 6, 2023 03:39

Conversation

ashuralyk commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashuralyk commented Aug 22, 2023

Uh oh!

Uh oh!

ashuralyk commented Aug 23, 2023

Uh oh!

ashuralyk commented Aug 24, 2023

Uh oh!

ashuralyk commented Aug 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashuralyk commented Aug 29, 2023

Uh oh!

blckngm commented Aug 29, 2023

Uh oh!

ashuralyk commented Aug 29, 2023

Uh oh!

ashuralyk commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjyr Aug 30, 2023

Choose a reason for hiding this comment

Uh oh!

jjyr left a comment

Choose a reason for hiding this comment

Uh oh!

ashuralyk commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashuralyk commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashuralyk commented Sep 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ashuralyk commented Aug 22, 2023 •

edited

Loading

ashuralyk commented Aug 27, 2023 •

edited

Loading

ashuralyk commented Aug 30, 2023 •

edited

Loading

ashuralyk commented Aug 31, 2023 •

edited

Loading

ashuralyk commented Sep 3, 2023 •

edited

Loading