Merged
Conversation
Contributor
|
this PR will trigger conflicts with #305, please take a look on it |
jjyr
force-pushed
the
test-ibc-framework-axon-chain-driver-rebased
branch
2 times, most recently
from
409647b to
e4981d7
Compare
jjyr
force-pushed
the
test-ibc-framework-axon-chain-driver-rebased
branch
from
e4981d7 to
d31d3ce
Compare
jjyr
force-pushed
the
test-ibc-framework-axon-chain-driver-rebased
branch
3 times, most recently
from
e7a7293 to
dacd98d
Compare
jjyr
force-pushed
the
test-ibc-framework-axon-chain-driver-rebased
branch
from
dacd98d to
d93ffc4
Compare
15168316096
reviewed
Aug 25, 2023
jjyr
force-pushed
the
test-ibc-framework-axon-chain-driver-rebased
branch
from
fcfec7d to
f5d3a1e
Compare
jjyr
force-pushed
the
test-ibc-framework-axon-chain-driver-rebased
branch
5 times, most recently
from
bf7f32a to
2cdae79
Compare
jjyr
force-pushed
the
test-ibc-framework-axon-chain-driver-rebased
branch
from
2cdae79 to
b617802
Compare
ashuralyk
approved these changes
Aug 31, 2023
Comment on lines
+132
to
+142
| impl AxonChain { | ||
| fn contract(&self) -> Result<Contract, Error> { | ||
| let key_entry = self | ||
| .keybase | ||
| .get_key(&self.config.key_name) | ||
| .map_err(Error::key_base)?; | ||
| let wallet = key_entry.into_ether_wallet().with_chain_id(self.chain_id); | ||
| let client = Arc::new(SignerMiddleware::new(self.client.clone(), wallet)); | ||
| let contract = Contract::new(self.config.contract_address, Arc::clone(&client)); | ||
| Ok(contract) | ||
| } |
Contributor
There was a problem hiding this comment.
why have to move generation of solidity contract instance out of bootstrap?
Collaborator
Author
There was a problem hiding this comment.
The IBC test-framework add keys after the node bootstrap. So if we initial the solidity contract in bootstrap, it will raise an error since the key hasn't been added.
Comment on lines
+108
to
+112
| ChainType::Ckb => { | ||
| // CKB only allow h256 as portId | ||
| let mut buf = [0u8; 32]; | ||
| buf[..8].copy_from_slice(b"transfer"); | ||
| PortId::from_str(H256::from(buf).to_string().as_str()).unwrap() |
Contributor
There was a problem hiding this comment.
in real packet test case of ckb, port_id should always be the lock_hash of business owners, but leaves this away until merging the next PR can fix it automatically
| prefix.to_string() | ||
| }; | ||
| let private_key = { | ||
| let data = hex::decode("37aa0f893d05914a4def0460c0a984d3611546cfb26924d7a7ca6e0db9950a2d") |
Contributor
There was a problem hiding this comment.
why choose this private key?
Collaborator
Author
There was a problem hiding this comment.
It is copied from the old test, if we change the key the deploy transaction becames invalid.
ashuralyk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ckb4ibc-testtoibc-test, make IBC tests ignorance the underlayer chains.ibc-testKnown issues: