fix: use correct arch on macOs for cache key#235
Merged
mpminardi merged 1 commit intotailscale:mainfrom Dec 11, 2025
Merged
Conversation
mpminardi
approved these changes
Dec 11, 2025
Member
mpminardi
left a comment
There was a problem hiding this comment.
Thank you for this @Lucino772 , and apologies for the miss here!
mpminardi
added a commit
that referenced
this pull request
Dec 11, 2025
Running make build was missed on #235 and subsequently missed by me when reviewing that PR (whoops). Updates #cleanup Signed-off-by: Mario Minardi <mario@tailscale.com>
mpminardi
added a commit
that referenced
this pull request
Dec 11, 2025
Running make build was missed on #235 and subsequently missed by me when reviewing that PR (whoops). Updates #cleanup Signed-off-by: Mario Minardi <mario@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am getting the following error when running this action on an Intel macOS runner:
After doing some research, I discovered that both ARM and Intel macOS runners are using the same cache key:
tailscale/1.90.6/macOS-amd64.Because of this, the first run on an ARM runner built and cached an ARM-compiled Tailscale binary. On a subsequent run, an Intel runner restored that cached binary, but since the binary was built for a different architecture, it failed to run.
macos-13 (Intel):
macos-15 (ARM64):
Solution
This PR fixes the
getTailscaleArchfunction so that ARM macOS runners return the correct architecture, ensuring that the generated cache key uses the correct architecture. On macOS runners specifically,config.archis only ever used when generating the cache key, it isn’t passed to the Go build command at all.PS: As a temporary fix, disabling the cache on macOS runners allows the workflow to run successfully