Update claims mocked address type, begins support for multi-address c…#322
Merged
Update claims mocked address type, begins support for multi-address c…#322
Conversation
drewstone
force-pushed
the
drew/claims-updates
branch
from
f409610 to
c720da1
Compare
salman01zp
reviewed
Nov 29, 2023
pallets/claims/src/lib.rs
Outdated
| signer: EthereumAddress, | ||
| dest: Option<T::AccountId>, | ||
| ) -> sp_runtime::DispatchResult { | ||
| println!("process_claim: signer: {:?}, dest: {:?}", signer, dest); |
Contributor
There was a problem hiding this comment.
Suggested change
| println!("process_claim: signer: {:?}, dest: {:?}", signer, dest); |
Contributor
Author
There was a problem hiding this comment.
Thanks I'll remove these as soon as the logic is finished.
drewstone
force-pushed
the
drew/claims-updates
branch
from
72fc6d9 to
09acb28
Compare
1xstj
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
AccountId32Option<T::AccountId>to support claiming directly to theEthereumAddresson EVM.Reference issue to close (if applicable)
Closes #311