Conversation
Contributor
|
Support it!
…On Wed, Jan 3, 2024 at 4:25 PM 1xstj ***@***.***> wrote:
@1xstj <https://github.com/1xstj> requested your review on: #398
<#398> feat : set address
prefixes as a code owner.
—
Reply to this email directly, view it on GitHub
<#398 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADELLFYTV3U4DRB3RJF7CM3YMXLGNAVCNFSM6AAAAABBMCF2WWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGM4DGNRXHEYTKNQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
drewstone
approved these changes
Jan 3, 2024
Contributor
|
Can we first check if this is valid for EVM chain ID too? |
Contributor
|
CC @shekohex |
Contributor
|
Ok there's no EVM for these numbers so we are good 👍 Can we add a task for https://chainlist.org |
4 tasks
Contributor
I will update the task or create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
for mainnet,
5845this would give us addresses with tg prefix for mainnet liketgGmBRR5yM53bvq8tTzgsUirpPtfCXngYYU7uiihmWFJhmYGMfor testnet,
3799this would give us addresses with tt prefix for testnet likettFELSU4MTyzpfsgZ9tFinrmox7pV7nF1BLbfYjsu4rfDYM74TODO : If approved, update in ss58 registry
Reference issue to close (if applicable)
Closes #388