fix(updater): fallback to passive mode & fix installerArgs deserialzation#1051
Merged
amrbashir merged 9 commits intoMar 11, 2024
Merged
Conversation
- Also fix installerArgs not working in tauri config
amrbashir
requested changes
Mar 8, 2024
Contributor
Author
|
Not sure why it can't pick up |
Contributor
Author
|
Strange, |
Contributor
Author
|
Found the problem, this part is still handled from tauri itself, not sure why changing |
amrbashir
approved these changes
Mar 11, 2024
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Sorry for the later reply, I have decided to revert back to OsString and go with your original solution, deserialize from string first.
Thanks for contribution
amrbashir
changed the title
installerArgs deserialzation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1015
Also fixes
installerArgsnot working in tauri config files