proposal-regexp-modifiers: Tests for syntax errors#3807
proposal-regexp-modifiers: Tests for syntax errors#3807
Conversation
Cases and templates to generate syntax error tests for regular expression modifiers, plus a few cases not worth templating.
Tests introduced by previous commits, generated from templates and cases by the usual scripts.
|
The main issue why this is still a draft, is that the templated test generator has some issues. /(?/*{ subpattern-add-modifiers }*/-/*{ subpattern-remove-modifiers }*/:a)//*{ global-modifiers }*/;But the generator cannot replace |
I created issue #3808 to report the problem. |
Based on PR tc39#3807 which had generated these tests from templates, but was stuck due to issue tc39#3808. Since these tests are a shipping blocker for v8, and tc39#3808 seems not straight-forward to fix, I modified the generated tests and removed the templates. One test is missing, as noted by @rbuckton in tc39#3960 (comment) to be added in a followup commit.
|
Closing in favour of #4016. |
This covers the syntax error cases from #3756.
This is an updated version of #3758 addressing review comments.