Regexp-modifiers syntax error tests#4016
Merged
Conversation
ioannad
changed the title
30 tasks
ptomato
approved these changes
Mar 5, 2024
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I only reviewed the new changes, but I previously reviewed #3758/#3807 and so have @gibson042 and @rbuckton, so I'm confident this can be merged.
What I will do before merging is squashing some of the commits.
ptomato
force-pushed
the
regexp-modifiers-syntax-tests
branch
from
1a24186 to
e943047
Compare
Co-Authored-By: Ioanna M. Dimitriou H <idimitriou@igalia.com>
…m, s As suggested in tc39#3960 (comment)
ptomato
force-pushed
the
regexp-modifiers-syntax-tests
branch
from
e943047 to
d3245cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds syntax tests for the RegExp modifiers proposal.
Based on PR #3807 which had generated these tests from templates, but was stuck due to issue #3808.
Since these tests are a shipping blocker for v8, and #3808 seems not straight-forward to fix, I modified the generated tests and removed the templates.
Additional tests suggested by @rbuckton are now added.
This should cover all the syntax error tests of the testing plan in #3756, and along with #3960 complete the tests for RegExp-modifiers.