Conversation
…ip01eventbuilder fix: restore sender overrides in NIP-01 builder
…ode-comment-in-nip01eventbuilder-dtnalz
…ip01eventbuilder-dtnalz style: simplify generics in NIP01 builder
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| public GenericEvent buildReplaceableEvent( | ||
| List<BaseTag> tags, Integer kind, String content) { | ||
| return buildReplaceableEvent(null, tags, kind, content); | ||
| } | ||
|
|
||
| public GenericEvent buildReplaceableEvent(List<BaseTag> tags, Integer kind, String content) { | ||
| return new GenericEventFactory<BaseTag>(resolveSender(null), kind, tags, content).create(); | ||
| return new GenericEventFactory<>(resolveSender(null), kind, tags, content).create(); |
There was a problem hiding this comment.
buildReplaceableEvent(List<BaseTag> tags, Integer kind, String content) is declared twice in succession—first delegating to a nonexistent (Identity, List<BaseTag>, Integer, String) overload and then constructing the event directly. Java rejects duplicate methods with identical signatures, so this class will not compile and the module’s tests cannot run. The delegating overload probably intended to accept an Identity parameter.
Useful? React with 👍 / 👎.
1 participant
Summary
Related issue: #____
What changed?
BREAKING
Review focus
Checklist