-
Notifications
You must be signed in to change notification settings - Fork 27
Chore/bump version 1.0.2 snapshot #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c966937
fix: restore sender overrides in NIP-01 builder
tcheeric 00870ac
style: use diamond operator in NIP01 builder
tcheeric b0b8d60
Merge pull request #485 from tcheeric/codex/address-code-comment-in-n…
tcheeric 38b1639
Merge branch 'chore/bump-version-1.0.2-SNAPSHOT' into codex/address-c…
tcheeric 042d019
Merge pull request #486 from tcheeric/codex/address-code-comment-in-n…
tcheeric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
nostr-java-api/src/test/java/nostr/api/unit/NIP01EventBuilderTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package nostr.api.unit; | ||
|
|
||
| import nostr.api.nip01.NIP01EventBuilder; | ||
| import nostr.base.PrivateKey; | ||
| import nostr.event.impl.GenericEvent; | ||
| import nostr.id.Identity; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| class NIP01EventBuilderTest { | ||
|
|
||
| // Ensures that an explicitly provided sender overrides the default identity. | ||
| @Test | ||
| void buildTextNoteUsesOverrideIdentity() { | ||
| Identity defaultSender = Identity.create(PrivateKey.generateRandomPrivKey()); | ||
| Identity overrideSender = Identity.create(PrivateKey.generateRandomPrivKey()); | ||
| NIP01EventBuilder builder = new NIP01EventBuilder(defaultSender); | ||
|
|
||
| GenericEvent event = builder.buildTextNote(overrideSender, "override"); | ||
|
|
||
| assertEquals(overrideSender.getPublicKey(), event.getPubKey()); | ||
| } | ||
|
|
||
| // Ensures that the builder falls back to the configured sender when no override is supplied. | ||
| @Test | ||
| void buildTextNoteUsesDefaultIdentityWhenOverrideMissing() { | ||
| Identity defaultSender = Identity.create(PrivateKey.generateRandomPrivKey()); | ||
| NIP01EventBuilder builder = new NIP01EventBuilder(defaultSender); | ||
|
|
||
| GenericEvent event = builder.buildTextNote("fallback"); | ||
|
|
||
| assertEquals(defaultSender.getPublicKey(), event.getPubKey()); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildReplaceableEvent(List<BaseTag> tags, Integer kind, String content)is declared twice in succession—first delegating to a nonexistent(Identity, List<BaseTag>, Integer, String)overload and then constructing the event directly. Java rejects duplicate methods with identical signatures, so this class will not compile and the module’s tests cannot run. The delegating overload probably intended to accept anIdentityparameter.Useful? React with 👍 / 👎.