Style Changes for Headsup Dispatch #66
Conversation
|
Add before and after screenshots to the PR comments |
|
Before and After pictures have been added |
|
This seems unnecessarily bold, especially given the rest of the UI is in normal casing. I understand maybe the determinant but does everything need to be caps? |
|
https://en.wikipedia.org/wiki/All_caps#Readability https://uxmovement.com/content/all-caps-hard-for-users-to-read/
Edit: I could totally get behind the determinant alone, but I'd have to be convinced pretty hard that the rest of it is more readable with caps |
|
I spoke with the line side officers and the dev coordinator, they(and I) agree and I'm going to change it so each word is capitalized, with the determinant in uppercase. The reason they requested uppercase was to hide dispatch inconsistencies regarding RPI. Would you be opposed to adding some regex that replaced mis-cased versions of Rpi with RPI? |
|
Here is the new alert with the following input |
No that seems fine |
ddbruce
left a comment
ddbruce
left a comment
There was a problem hiding this comment.
Looks fine, but let's take this time to clean up the code such that #dispatch is in the dispatch CSS file and not in both the light and dark mode files. It is the same CSS, right?
The code has been cleaned, it is the same css |
* Master -> dev (#44) Co-authored-by: Logan Ramos <lramos15@gmail.com> * Add CAD Display from Herald (#65) * Restructured Index.html and added endpoint for herald to push dispatch info to * Styled Dispatch alerts, set dispatch alert duration to three minutes, and fixed odds and ends * add dev env * add dev workflow * match database fields * add css file to index.html * this is what happens when you copy and paste a line * eslint * work on dispatch styling * more styling * add dispatch time * fix dispatch time text * Style Changes for Headsup Dispatch (#66) * Changed Styling to capitalize dispatch info by request of RPIA dev-team coordinator * Capitalize the start of words and Uppercase the determinant in Dispatch Alerts * Moved Dispatch style to style-dispatch.scss * BugFix: Fix issues with dispatches that occur within 3 minutes of each other (#68) * Changed Styling to capitalize dispatch info by request of RPIA dev-team coordinator * Capitalize the start of words and Uppercase the determinant in Dispatch Alerts * Moved Dispatch style to style-dispatch.scss * Fixed issues with dispatches that occur within 3 minutes of each other * Correct Logic Errors in ClearDispatch Timeout * Added authentication token for herald dispatch * 1.5.0 * Clean Code and Add Admin Authentication (#70) * Spell checking and code adjustments * Added token authentication to admin POST endpoints * restructure admin authentication * fix double-dispatch clearing time issue * update build status badge --------- Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Christian <57967583+CKegel@users.noreply.github.com>
3 participants
Changed style of info to all capital letters for clarity.
Before:
After: