BugFix: Fix issues with dispatches that occur within 3 minutes of each other #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbruce
reviewed
Mar 14, 2023
public/js/whiteboard.js
Outdated
|
|
||
| function handleDispatch(determinant, complaint, location) { | ||
| clearDispatch(); | ||
| clearTimeout(dispatchTimeoutID); |
Member
There was a problem hiding this comment.
Shouldn't this be
if (dispatchTimeoutID != "") {
clearTimeout(dispatchTimeoutID);
dispatchTimeoutId = "";
}
?
Contributor
Author
There was a problem hiding this comment.
That is most definitely more correct if not correct.
Contributor
Author
There was a problem hiding this comment.
Shouldn't this be
if (dispatchTimeoutID != "") { clearTimeout(dispatchTimeoutID); dispatchTimeoutId = ""; }?
I've made the appropriate changes to reflect this corrected logic
ddbruce
requested changes
Mar 15, 2023
public/js/whiteboard.js
Outdated
| } | ||
|
|
||
| function handleDispatch(determinant, complaint, location) { | ||
| if(dispatchTimeoutID != ""){ |
Member
There was a problem hiding this comment.
Please add a space after if and before (
Member
There was a problem hiding this comment.
ESLint should take care of these things. Are you using that?
Contributor
Author
|
An Authentication token has been added for the dispatch endpoint |
ddbruce
added a commit
that referenced
this pull request
Mar 21, 2023
* Master -> dev (#44) Co-authored-by: Logan Ramos <lramos15@gmail.com> * Add CAD Display from Herald (#65) * Restructured Index.html and added endpoint for herald to push dispatch info to * Styled Dispatch alerts, set dispatch alert duration to three minutes, and fixed odds and ends * add dev env * add dev workflow * match database fields * add css file to index.html * this is what happens when you copy and paste a line * eslint * work on dispatch styling * more styling * add dispatch time * fix dispatch time text * Style Changes for Headsup Dispatch (#66) * Changed Styling to capitalize dispatch info by request of RPIA dev-team coordinator * Capitalize the start of words and Uppercase the determinant in Dispatch Alerts * Moved Dispatch style to style-dispatch.scss * BugFix: Fix issues with dispatches that occur within 3 minutes of each other (#68) * Changed Styling to capitalize dispatch info by request of RPIA dev-team coordinator * Capitalize the start of words and Uppercase the determinant in Dispatch Alerts * Moved Dispatch style to style-dispatch.scss * Fixed issues with dispatches that occur within 3 minutes of each other * Correct Logic Errors in ClearDispatch Timeout * Added authentication token for herald dispatch * 1.5.0 * Clean Code and Add Admin Authentication (#70) * Spell checking and code adjustments * Added token authentication to admin POST endpoints * restructure admin authentication * fix double-dispatch clearing time issue * update build status badge --------- Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Christian <57967583+CKegel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.