CHI-3566: Add contactField permission tests and fix default-allow behavior#3912
Closed
Copilot wants to merge 2 commits intoCHI-3566-contact_field_view_permissionsfrom
Closed
CHI-3566: Add contactField permission tests and fix default-allow behavior#3912Copilot wants to merge 2 commits intoCHI-3566-contact_field_view_permissionsfrom
Copilot wants to merge 2 commits intoCHI-3566-contact_field_view_permissionsfrom
Conversation
6 tasks
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add contact field permission support
CHI-3566: Add contactField permission tests and fix default-allow behavior
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds comprehensive test coverage for
contactFieldpermissions and fixes the permission logic to implement default-allow for unspecified fields.Key Changes:
Test Coverage: Added 28 tests covering all contactField permission edge cases:
Permission Logic Fix: Modified
contactFieldcase inrules.ts:true(allow) for fields not explicitly restrictedcontact.createdAtinstead of non-existenttarget.createdAtExample Behavior:
Checklist
Other Related Issues
None
Verification steps
Run the test suite:
All 293 tests should pass, including the new contactField permission tests.
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.