CHI-3566: Add contact field permission support#3901
CHI-3566: Add contact field permission support#3901stephenhand wants to merge 13 commits intomasterfrom
Conversation
|
@copilot Enhance the rules.test.ts in plugin-hrm-form to include specific tests for permissions with the contactField target kind The additional tests should cover addtional scenarios including, but not limited to:
|
|
@stephenhand I've opened a new pull request, #3912, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot Enhance the rules.test.ts in plugin-hrm-form to include specific tests for permissions with the contactField target kind The additional tests should cover addtional scenarios including, but not limited to:
|
|
@stephenhand I've opened a new pull request, #3913, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Add comprehensive test coverage for contactField permission rules
…issions' into CHI-3566-contact_field_view_permissions
|
@copilot enhance permissions unit tests to add coverage for the new 'nobody' condition |
|
@stephenhand I've opened a new pull request, #3917, to work on those changes. Once the pull request is ready, I'll request review from you. |
… target kinds Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
CHI-3566: Add 'nobody' condition test coverage for permission rules
gpaoloni
left a comment
There was a problem hiding this comment.
Looks good to me! Only having to change ContactDetailsSectionForm.tsx for all the changes to take effect is lovely to see.
Description
Adds support for loading contactField type permissions from the backend
Makes fields without view permissions hidden
Makes fields without edit permission read only
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P