Skip to content

Comments

CHI-3566: Add 'nobody' condition test coverage for permission rules#3917

Merged
stephenhand merged 2 commits intoCHI-3566-contact_field_view_permissionsfrom
copilot/sub-pr-3901-again
Feb 18, 2026
Merged

CHI-3566: Add 'nobody' condition test coverage for permission rules#3917
stephenhand merged 2 commits intoCHI-3566-contact_field_view_permissionsfrom
copilot/sub-pr-3901-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

Description

Enhanced permission unit tests to cover the nobody condition—a user-based condition that always evaluates to false, effectively denying all permissions. Tests verify denial behavior across all permission target kinds.

Test coverage added for:

  • CaseActions
  • ContactActions
  • ProfileActions
  • ProfileSectionActions
  • ViewIdentifiersAction
  • ContactFieldActions

Key test scenarios:

  • nobody alone always denies access
  • nobody combined with other conditions in same set still denies
  • nobody in one condition set can be overridden by another condition set evaluating to true
  • ContactField-specific: nobody without field condition doesn't restrict fields (follows field-specific permission logic)

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags added
  • Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

Run permission unit tests:

cd plugin-hrm-form
npm test -- --testPathPatterns=rules.test.ts

All new nobody condition tests should pass.

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

… target kinds

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot AI changed the title [WIP] Add support for contact field permission features CHI-3566: Add 'nobody' condition test coverage for permission rules Feb 18, 2026
Copilot AI requested a review from stephenhand February 18, 2026 10:10
@stephenhand stephenhand marked this pull request as ready for review February 18, 2026 10:37
@stephenhand stephenhand merged commit be1e629 into CHI-3566-contact_field_view_permissions Feb 18, 2026
26 checks passed
@stephenhand stephenhand deleted the copilot/sub-pr-3901-again branch February 18, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants