Add comprehensive test coverage for contactField permission rules#3913
Merged
stephenhand merged 3 commits intoCHI-3566-contact_field_view_permissionsfrom Feb 16, 2026
Merged
Conversation
6 tasks
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add contact field permission support
Add comprehensive test coverage for contactField permission rules
Feb 16, 2026
stephenhand
approved these changes
Feb 16, 2026
6f7f7fb
into
CHI-3566-contact_field_view_permissions
26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds test suite for contactField target kind permission evaluation, covering edge cases in field-specific condition filtering logic.
Test Coverage
everyone,isSupervisor,isOwner) apply uniformly across all fields48 test cases added (24 per action:
viewContactField,editContactField)Checklist
Other Related Issues
None
Verification steps
Run the test suite:
All 303 tests should pass.
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.