Skip to content

Add comprehensive test coverage for contactField permission rules #3913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenhand merged 3 commits into from
Feb 16, 2026
Merged

Add comprehensive test coverage for contactField permission rules #3913

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dec2c0
Initial plan
Copilot Feb 16, 2026
74c35dd
Add comprehensive ContactField permission tests
Copilot Feb 16, 2026
5bbc33b
Fix ESLint formatting issues in rules.test.ts
Copilot Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
225 changes: 225 additions & 0 deletions plugin-hrm-form/src/___tests__/permissions/rules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
actionsMaps,
CaseActions,
ContactActions,
ContactFieldActions,
PermissionActions,
ProfileActions,
ProfileSectionActions,
Expand Down Expand Up @@ -612,3 +613,227 @@ describe('ViewIdentifiersAction', () => {
},
);
});

describe('ContactFieldActions', () => {
afterEach(() => {
cleanupInitializedCan();
});

const mockContact = { twilioWorkerId: 'owner', createdAt: new Date().toISOString() };
const testField = 'rawJson.childInformation.name';
const otherField = 'rawJson.childInformation.age';

each(
Object.values(ContactFieldActions)
.flatMap(action => [
// Test 1: Fields not specified by a 'field' condition in any condition set are always allowed
{
action,
conditionsSets: [['isSupervisor'], [{ field: otherField }]],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'field is not specified in any condition set - should be allowed',
},
{
action,
conditionsSets: [[{ field: otherField }]],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'field is not specified (only other field specified) - should be allowed',
},
// Test 2: Condition sets with no field condition will allow any field if they evaluate to true
{
action,
conditionsSets: [['everyone']],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'no field condition, everyone condition evaluates to true',
},
{
action,
conditionsSets: [['isSupervisor']],
workerSid: 'not owner',
isSupervisor: true,
field: testField,
expectedResult: true,
expectedDescription: 'no field condition, isSupervisor condition evaluates to true',
},
{
action,
conditionsSets: [['isOwner']],
workerSid: 'owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'no field condition, isOwner condition evaluates to true',
},
// Test 3: If condition sets with no field condition evaluate to false, but there are no condition sets
// with a field condition matching the field being checked, the action should be allowed
{
action,
conditionsSets: [['isSupervisor']],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription:
'no field-specific conditions exist, so field is allowed even though isSupervisor is false',
},
{
action,
conditionsSets: [['isOwner'], ['isSupervisor']],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'no field-specific conditions exist, field is allowed even though conditions are false',
},
{
action,
conditionsSets: [['isSupervisor'], [{ field: otherField }]],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription:
'field has no specific conditions (only other field specified), allowed even though isSupervisor is false',
},
// Test 4: Multiple field conditions in the same set specifying different fields means
// that condition set will be filtered out, demonstrating it can't restrict a field on its own
{
action,
conditionsSets: [[{ field: testField }, { field: otherField }]],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription:
'multiple different field conditions in same set gets filtered out, no field-specific conditions remain, so allowed',
},
{
action,
conditionsSets: [[{ field: testField }, { field: otherField }], ['everyone']],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'conflicting field conditions get filtered out, everyone condition allows',
},
{
action,
conditionsSets: [[{ field: testField }, { field: otherField }], ['isSupervisor']],
workerSid: 'not owner',
isSupervisor: true,
field: testField,
expectedResult: true,
expectedDescription: 'conflicting field conditions get filtered out, isSupervisor allows',
},
{
action,
conditionsSets: [[{ field: testField }, { field: otherField }], ['isSupervisor']],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription:
'conflicting field conditions get filtered out, no field-specific conditions remain even though isSupervisor is false, so allowed',
},
{
action,
conditionsSets: [
[{ field: testField }, { field: otherField }],
[{ field: testField }, 'isOwner'],
],
workerSid: 'owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription:
'conflicting field conditions filtered out, but valid field condition with isOwner passes',
},
{
action,
conditionsSets: [
[{ field: testField }, { field: otherField }],
[{ field: testField }, 'isOwner'],
],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: false,
expectedDescription:
'conflicting field conditions filtered out, valid field condition exists but isOwner is false',
},
// Additional comprehensive tests
{
action,
conditionsSets: [[{ field: testField }, 'isOwner']],
workerSid: 'owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'field condition matches and isOwner is true',
},
{
action,
conditionsSets: [[{ field: testField }, 'isOwner']],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: false,
expectedDescription: 'field condition matches but isOwner is false',
},
{
action,
conditionsSets: [[{ field: testField }], ['isSupervisor']],
workerSid: 'not owner',
isSupervisor: true,
field: testField,
expectedResult: true,
expectedDescription: 'field condition in first set, isSupervisor in second set evaluates to true',
},
{
action,
conditionsSets: [[{ field: testField }]],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'only field condition with no additional conditions - always true',
},
{
action,
conditionsSets: [[{ field: otherField }, 'everyone']],
workerSid: 'not owner',
isSupervisor: false,
field: testField,
expectedResult: true,
expectedDescription: 'other field condition with everyone - field not specified so allowed',
},
])
.map(addPrettyPrintConditions),
).test(
`Should return $expectedResult for action $action when $expectedDescription and conditionsSets are $prettyConditionsSets`,
async ({ action, conditionsSets, workerSid, isSupervisor, field, expectedResult }) => {
const rules = buildRules(conditionsSets, 'contactField');
fetchPermissionRulesSpy.mockResolvedValue(rules);

mockPartialConfiguration({
workerSid,
isSupervisor,
});

await validateAndSetPermissionRules();

const can = getInitializedCan();

expect(can(action, { contact: mockContact, field })).toBe(expectedResult);
},
);
});
Loading