Enable Server-Side Apply for finalizers management#1635
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Apr 28, 2026
Merged
Enable Server-Side Apply for finalizers management#1635tekton-robot merged 1 commit intotektoncd:mainfrom
tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
Leverages functionality added here: knative/pkg#3275 Options documented here: https://github.com/knative/pkg/blob/main/controller/options.go#L31-L40
tekton-robot
added
the
size/S
Member
|
/kind misc |
tekton-robot
added
the
kind/misc
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| FinalizerName: "chains.tekton.dev/pipelinerun", // TODO: unique name required? | ||
| SkipStatusUpdates: true, | ||
| ConfigStore: cfgStore, | ||
| FinalizerName: "chains.tekton.dev/pipelinerun", // TODO: unique name required? |
Contributor
Author
There was a problem hiding this comment.
The change is already merged and the line with the comment was not part of my change, but I can remove it in another change. BTW this is a question and the answer is yes, unique name is required in the context of all Tekton controllers working on the same type of object. So not sure if removing or clarifying is more appropriate here.
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverages functionality added here:
knative/pkg#3275
Options documented here:
https://github.com/knative/pkg/blob/main/controller/options.go#L31-L40
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes