Skip to content

Enable Server-Side Apply for finalizers management #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekton-robot merged 1 commit into from
Apr 28, 2026
+10 −6
Merged

Enable Server-Side Apply for finalizers management #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/reconciler/pipelinerun/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,11 @@ func NewNamespacesScopedController(namespaces []string) func(ctx context.Context

return controller.Options{
// The chains reconciler shouldn't mutate the pipelinerun's status.
SkipStatusUpdates: true,
ConfigStore: cfgStore,
FinalizerName: "chains.tekton.dev/pipelinerun", // TODO: unique name required?
SkipStatusUpdates: true,
ConfigStore: cfgStore,
FinalizerName: "chains.tekton.dev/pipelinerun", // TODO: unique name required?
Copy link
Copy Markdown
Contributor

@anithapriyanatarajan anithapriyanatarajan Apr 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enarha - could we remove this TODO comment?

Copy link
Copy Markdown
Contributor Author

@enarha enarha Apr 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is already merged and the line with the comment was not part of my change, but I can remove it in another change. BTW this is a question and the answer is yes, unique name is required in the context of all Tekton controllers working on the same type of object. So not sure if removing or clarifying is more appropriate here.

UseServerSideApplyForFinalizers: true,
FinalizerFieldManager: "tekton-chains-controller/finalizers",
}
})

Expand Down
8 changes: 5 additions & 3 deletions pkg/reconciler/taskrun/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,11 @@ func NewNamespacesScopedController(namespaces []string) func(ctx context.Context

return controller.Options{
// The chains reconciler shouldn't mutate the taskrun's status.
SkipStatusUpdates: true,
ConfigStore: cfgStore,
FinalizerName: "chains.tekton.dev/taskrun",
SkipStatusUpdates: true,
ConfigStore: cfgStore,
FinalizerName: "chains.tekton.dev/taskrun",
UseServerSideApplyForFinalizers: true,
FinalizerFieldManager: "tekton-chains-controller/finalizers",
}
})

Expand Down
Loading