Add enable-api-fields field for TektonTriggers #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Triggers 0.16 release a new field was added `enable-api-field` which can be used to enable features which are in `alpha`. So this PR is to add `enable-api-fields` in TektonConfig/TektonTrigger so that it can be configured via operator. Signed-off-by: vinamra28 <vinjain@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
Contributor
|
The following is the coverage report on the affected files.
|
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vinamra28
added a commit
to vinamra28/operator
that referenced
this pull request
Sep 20, 2021
With PR tektoncd#411 the enable-api-fields for triggers was set in config-defaults-triggers ConfigMap whereas it should be added in feature-flags-triggers ConfigMap so shifting that.
3 tasks
vinamra28
added a commit
to vinamra28/operator
that referenced
this pull request
Sep 20, 2021
With PR tektoncd#411 the enable-api-fields for triggers was set in config-defaults-triggers ConfigMap whereas it should be added in feature-flags-triggers ConfigMap so shifting that.
tekton-robot
pushed a commit
that referenced
this pull request
Sep 20, 2021
With PR #411 the enable-api-fields for triggers was set in config-defaults-triggers ConfigMap whereas it should be added in feature-flags-triggers ConfigMap so shifting that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since Triggers 0.16 release a new field was added
enable-api-fieldwhich can be used to enable features which are in
alpha.So this PR is to add
enable-api-fieldsin TektonConfig/TektonTriggerso that it can be configured via operator.
Signed-off-by: vinamra28 vinjain@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes