Fix move enable-api-fields to feature-flags CM #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
vdemeester
approved these changes
Sep 20, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm 👍 /hold for others to review 😄 |
With PR tektoncd#411 the enable-api-fields for triggers was set in config-defaults-triggers ConfigMap whereas it should be added in feature-flags-triggers ConfigMap so shifting that.
vinamra28
force-pushed
the
move-enable-api-to-feature-flag-cm
branch
from
1ee4e8d to
2640153
Compare
tekton-robot
added
size/M
sm43
reviewed
Sep 20, 2021
| type TriggersProperties struct { | ||
| EnableApiFields string `json:"enable-api-fields,omitempty"` | ||
| // +optional | ||
| OptionalTriggersProperties `json:",inline"` |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With PR #411 the enable-api-fields for triggers was set in
config-defaults-triggers ConfigMap whereas it should be added in
feature-flags-triggers ConfigMap so shifting that.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes