Making sure that TestCase can be hashed

[gone]

Defining a custom eq method will prevent a TestCase instance from being hashed, and the django testing library attempts to hash all TestCases.

[ddormer]

I don't think the hash should default to self.id because that will result in each test having the same hash. Instead __hash__ should be set to unittest.TestCase.__hash__.

[javiromero]

I'm facing the exact same issue when running Django 1.11.x tests with Python 3. Is there any chance this gets merged?

[ddormer]

Ping @jml and @gone :)

[jml]

Unsubscribe

…

On Thu, 15 Nov 2018 at 12:41, Darren Dormer ***@***.***> wrote: Ping @jml <https://github.com/jml> and @gone <https://github.com/gone> :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#248 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHq6i_a0Scfzw5q8pPMM_d2NhYLO2j5ks5uvWDfgaJpZM4LqiCw> .

[Flimm]

This looks useful to me! While waiting for the merge, I guess I can copy and paste the __hash__ implementation.

[gone]

@ddormer sorry about ghosting - missed the notification for this.

I see what you mean about using every test within the same case having the same id, but that's only going to be used if unittest.TestCase.__hash__ isn't set - so it will prefer unittest.testcase if it's present and only all back to id if it's not there.

What's a good default to use when unittest.TestCase.__hash__ is None?

[gone]

Bumping this up - been more active lately if there's desire to get this merged

[gone]

Updated - let me know if you'd like me to squash