Skip to content

Making sure that TestCase can be hashed #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelmer merged 3 commits into from
Jul 1, 2022
Merged

Making sure that TestCase can be hashed #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5653755
Making sure that TestCase can be hashed
gone Jan 22, 2017
cf6b8b0
less code
gone Aug 29, 2019
e223b5d
simplifying code
gone May 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions testtools/testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,8 @@ def __eq__(self, other):
return False
return self.__dict__ == other.__dict__

__hash__ = unittest.TestCase.__hash__

def __repr__(self):
# We add id to the repr because it makes testing testtools easier.
return f"<{self.id()} id=0x{id(self):0x}>"
Expand Down
4 changes: 4 additions & 0 deletions testtools/tests/test_testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ def test_shortDescription_specified(self):
test = PlaceHolder("test id", "description")
self.assertEqual("description", test.shortDescription())

def test_testcase_is_hashable(self):
test = hash(self)
self.assertEqual(unittest.TestCase.__hash__(self), test)

def test_repr_just_id(self):
# repr(placeholder) shows you how the object was constructed.
test = PlaceHolder("test id")
Expand Down