[SDW UCM2][CML][BUG]Both S/PDIF,S/PDIF 1, S/PDIF 2 values can't be reset after changing default value manually.

[sinahuang]

Describe the bug
Both S/PDIF,S/PDIF 1, S/PDIF 2 values can't be reset after changing default value manually.

More info:
Need manually change S/PDIF,S/PDIF 1, S/PDIF 2 to unmute in alsamixer can recover.
UCM2:
https://github.com/thesofproject/alsa-ucm-conf (commit: 4722f5b ) +thesofproject/alsa-ucm-conf#29

To Reproduce
1.Boot up system successfully.
2.Manually change S/PDIF,S/PDIF 1, S/PDIF 2 to unmute in alsamixer.
3.Power cycle system.
4.Check alsamixer

Reproduce rate
5/5

Expected result
S/PDIF,S/PDIF 1, S/PDIF 2 value should can be reset to default value after power cycle system.

Actual result
S/PDIF,S/PDIF 1, S/PDIF 2 can't be reset to default value after power cycle system .

Test recipe

Kernel:https://github.com/thesofproject/linux/commits/topic/sof-dev commit:052e45d
FW: https://github.com/thesofproject/sof/commits/master commit: b4e8b1e4
Tplg: Same with FW branch, sof-cml-rt711-rt1308-rt715.tplg
Platform:CML-H Laptop with codec ALC711, 2 x RT1308, RT715 in SDW mode.

[plbossart]

@sinahuang the SPDIF controls are really the IEC958 ones, which are explicitly used in the UCM file.

https://github.com/thesofproject/alsa-ucm-conf/blob/bd7e4d619d6c721a2cd47f054a107964bdcc94b2/ucm2/sof-soundwire/Hdmi.conf#L13

You will need to provide more details on what you are doing to trigger this error, works fine for me.

[sinahuang]

Tried with below scenarios, issue can be triggered.
scenario 1:
Mute S/PDIF,S/PDIF 1, S/PDIF 2 in alsamixer manually then switch output source to speaker in sound setting, it cannot be unmuted in alsamixer.
scenario2:
Mute S/PDIF,S/PDIF 1, S/PDIF 2 in alsamixer manually, then tried to reboot system, checked alsamixer after booting up successfully, they are still muted.

amixer contents.txt

[plbossart]

That's an invalid test, sorry. If you use UCM, you should not play with alsamixer and change the values in the background. That will lead to a consistency issue.

[kv2019i]

@sinahuang @libinyang I agree with @plbossart , the expected behaviour is not correct. The SPDIF controls for HDMI/DP are unmuted when playback to HDMI/DP monitor is activated via UCM. So unless you connect a monitor and do playback, it is expected for the controls to be muted.

[libinyang]

@sinahuang @libinyang I agree with @plbossart , the expected behaviour is not correct. The SPDIF controls for HDMI/DP are unmuted when playback to HDMI/DP monitor is activated via UCM. So unless you connect a monitor and do playback, it is expected for the controls to be muted.

@kv2019i The problem is that SPDIF volume initial state is unknown especially that user may touch this volume. So it is better that we setup the volume to a proper value and mute the S/PDIF to mute. And when HDMI is connected, the S/PDIF is unmuted automatically.
I have submitted a patch for this issue to setup to a proper value: thesofproject/alsa-ucm-conf#35
This is still open whether we should set the volume or not. If we don't want to set the volume, I will close my PR.