Sof soundwire #29

plbossart · 2020-03-16T22:36:33Z

This goes together with

This seems to work except for headphones, wondering if I am missing a setting for RT711. @bardliao @RanderWang can you take a look?

Add conditional inclusion of sections Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

bardliao · 2020-03-17T08:37:29Z

This goes together with

thesofproject/linux#1889

This seems to work except for headphones, wondering if I am missing a setting for RT711. @bardliao @RanderWang can you take a look?

I didn't see any issue from a06d285
But both Headset Mic and SoundWire microphones doesn't work when I tested it with my Dell laptop. However, both headphone and speaker playback work fine. I am wondering if the enable sequence is applied. Actually, I tried modifying cset "name='rt711 DAC Surr Playback Volume' 87" to cset "name='rt711 DAC Surr Playback Volume' 30" in RT711.conf. The 'rt711 DAC Surr Playback Volume' control is still 87 when I play with headphone.

plbossart · 2020-03-17T10:27:41Z

This goes together with
thesofproject/linux#1889
This seems to work except for headphones, wondering if I am missing a setting for RT711. @bardliao @RanderWang can you take a look?

I didn't see any issue from a06d285
But both Headset Mic and SoundWire microphones doesn't work when I tested it with my Dell laptop. However, both headphone and speaker playback work fine. I am wondering if the enable sequence is applied. Actually, I tried modifying cset "name='rt711 DAC Surr Playback Volume' 87" to cset "name='rt711 DAC Surr Playback Volume' 30" in RT711.conf. The 'rt711 DAC Surr Playback Volume' control is still 87 when I play with headphone.

For me it's the headphone that doesn't work, but the results are different if I do modprobe snd-sof-pci with the headphone inserted or not. Clearly PulseAudio or alsa-lib are not taking the information into account.

bardliao · 2020-03-17T11:52:58Z

For me it's the headphone that doesn't work, but the results are different if I do modprobe snd-sof-pci with the headphone inserted or not. Clearly PulseAudio or alsa-lib are not taking the information into account.

Does "headphone doesn't work" here mean "Headphone" is not showed in sound setting or it is showed but there is no output when you play with headphone? It works on my side. I can see "headphone" is showed if a headphone is inserted, and disappear when the headphone is unplugged. And of course it plays well.

plbossart · 2020-03-17T12:27:16Z

For me it's the headphone that doesn't work, but the results are different if I do modprobe snd-sof-pci with the headphone inserted or not. Clearly PulseAudio or alsa-lib are not taking the information into account.

Does "headphone doesn't work" here mean "Headphone" is not showed in sound setting or it is showed but there is no output when you play with headphone? It works on my side. I can see "headphone" is showed if a headphone is inserted, and disappear when the headphone is unplugged. And of course it plays well.

Ah, you got me on the 'work' usage ;-)

What I meant is that the headset is well detected, but in some cases where I insert the headset after the start and run the test app I hear nothing. the funny thing is that I can play with the hw:0,0 device while the test app is running and hear audio, so I suspect PulseAudio does not even open the device.

Maybe this is also an install issue, I added the libasound .deb package to get ucm2 support, but maybe I need both the latest alsa-lib and pulseaudio installed.

libinyang · 2020-03-18T07:54:28Z

For me it's the headphone that doesn't work, but the results are different if I do modprobe snd-sof-pci with the headphone inserted or not. Clearly PulseAudio or alsa-lib are not taking the information into account.

Does "headphone doesn't work" here mean "Headphone" is not showed in sound setting or it is showed but there is no output when you play with headphone? It works on my side. I can see "headphone" is showed if a headphone is inserted, and disappear when the headphone is unplugged. And of course it plays well.

Ah, you got me on the 'work' usage ;-)

What I meant is that the headset is well detected, but in some cases where I insert the headset after the start and run the test app I hear nothing. the funny thing is that I can play with the hw:0,0 device while the test app is running and hear audio, so I suspect PulseAudio does not even open the device.

Maybe this is also an install issue, I added the libasound .deb package to get ucm2 support, but maybe I need both the latest alsa-lib and pulseaudio installed.

@plbossart Yes, if you are using the built-in pulseaudio of Ubuntu 18.04, it will not support UCM2.

libinyang · 2020-03-18T08:20:20Z

ucm2/sof-soundwire/RT1308-1.conf

+	Condition {
+		Type String
+		Haystack "${CardComponents}"
+        	Needle "spk:rt1308" 


I didn't find the definition of "spk:rt1308" of the components in the source code. Maybe I missed something?

libinyang · 2020-03-18T11:50:11Z

@plbossart @bardliao
I have run the verify-ucm-config.sh in sof-ci/sof-test on sof-soundwire config. The test result shows there is no grammar issue.
And what platform are you using? Dell Olympic? If so, I think you have already renamed sof-soundwire to sof-sdw-rt711-1308-715 and put them in alsa/ucm2 folder, right?
After fixing the Needle string issue, I believe the UCM2 will work.

And BTW, I checked with Jaska and confirmed that his pulseaudio doesn't support UCM2. I have tested on the latest pulseaudio with alsa-lib from http://sof-ci-storage.sh.intel.com/share/alsa/alsa-lib/libasound2_1.2.1.2-intel_amd64.deb, it supports UCM2.

bardliao · 2020-03-18T12:44:45Z

I think you have already renamed sof-soundwire to sof-sdw-rt711-1308-715

This goes together with thesofproject/linux#1889. So no rename needed.

libinyang · 2020-03-18T13:31:09Z

I think you have already renamed sof-soundwire to sof-sdw-rt711-1308-715

This goes together with thesofproject/linux#1889. So no rename needed.

@bardliao Thanks. And I see the CardComponents definition in that patchset.

libinyang · 2020-03-18T14:14:35Z

@plbossart Thanks for the work on UCM2. I planned to support UCM2 after the Dell project. Actually I did have some UCM2 configs for our CI DUTs (but I didn't prepare the soundwire UCM2). I will polish them and submit them later after I finish my current task.
Back to this sof-soundwire UCM2 config. I refined my kernel code to support the correct CardComponents on my Dell Olympic with updated pulseaudio and alsa-lib. It works well. Speaker, Headphone, embedded MIC and Headset MIC worked. (I didn't test HDMI).
I'm planning to build a pulseaudio deb package which supports UCM2 and submit to the server.

libinyang · 2020-03-18T14:20:53Z

ucm2/sof-soundwire/RT711.conf

+				cset "name='rt711 ADC 08 Capture Switch' 1"
+				cset "name='rt711 AMIC Volume' 1"
+			]
+


missed DisableSequence?

those where the settings we've used so far, I don't know if there is a need to turn something off.
Likewise from a hardware perspective, there is no conflict between headphone and speaker, they can work at the same time, but that may get in the way of user-experience

OK. Mostly if we switch on something in enablesequence, we will switch off it in disablesequence unless it impacts on other streams. However, even we don't switch off it, it still works well because pulseaudio will switch stream automatically.

how about to unify this UCM setting as other codecs ?

DisableSequence [ cset "name='rt711 ADC 08 Capture Switch' 0" ]

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Settings provided by M, Naveen <naveen.m@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

ClarexZhou · 2020-03-26T01:43:29Z

Test UCM2 SDW PR#29 on CML-U with 711-1308-mono-715 in SDW mode. Many non-soundwire commits in PR#29 and apply failed. So only applied 3 sof-soundwire commit.

Test Environment:
Ubuntu: 20.04 (from cdimage.ubuntu.com/ubuntu/daily-live) , with alsa-lib: 1.2.2-2.1, Pulseaudio: 13.99.1
Kernel: Sof-dev (commit:33f864de)
Firmware &tplg: Master(commit: b8b96a20) + PR #2603 to avoid bug #2570 + PR# 2358 to enable mute LED.

Found below issues (No issues without UCM2): add dmesg with pulseaduio log for issue 1 and issue 2.
syslog.txt

Runtime PM keeps active after boot up
Call trace then System hang when start headset aplay/arecord or select Headphone as output source from sound setting
MIC mute LED won’t light on, but mute/unmute control is working.
Both rt1308-1 DAC L and rt1308-1 DAC R are muted in default
Won’t auto switch output source when plug headset.
HDMI/DP jack detection works OK. Audio output can auto switch to speaker if disconnect HDMI/DP during paplay via HDMI/DP. -> This is expected behavior, not issue.
Both HDMI and DP connected, HDMI is HDMI1/DP1 output, DP is HDMI2/DP2. ->S/PDIF is muted in default, need to unmute manually
“rt715 ADC 07 Capture Switch” is default off, need to manually switch to on for DMIC capture
DMIC default volume is too low. Need set default volume for DMIC “PGA5.0 5 Master”

RanderWang · 2020-03-26T08:46:50Z

ucm2/sof-soundwire/RT711.conf

+			Comment	"Headphone"
+
+			EnableSequence [
+				cset "name='rt711 DAC Surr Playback Volume' 87"


we need to add "cset "name='Headphone Switch' on" here, or no output in headphone when switch speaker to headphone in sound setting

RanderWang · 2020-03-26T08:56:42Z

@plbossart I installed 19.10 and tested on CML-U. Playback & capture work now and all the mixers are correct. Two issues: first output doesn't move to correct endpoint when switch between headphone & speaker in sound setting. I gave a solution confirmed by Clare in above comments. Another issue is: output doesn't move to correct endpoint automatically when plug or remove headphone. I don't find a solution now.

libinyang · 2020-03-26T13:43:59Z

@plbossart I installed 19.10 and tested on CML-U. Playback & capture work now and all the mixers are correct. Two issues: first output doesn't move to correct endpoint when switch between headphone & speaker in sound setting. I gave a solution confirmed by Clare in above comments. Another issue is: output doesn't move to correct endpoint automatically when plug or remove headphone. I don't find a solution now.

@RanderWang If I remember correctly, what you mentioned is the known issue. If we use multiple profiles, the switching between HS and Speaker will be fixed.

Apply the values suggested by Libin in PR#28 The split between profiles is not done, not sure why it was needed in the first place. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

@shumingfan

Use settings provided by @shumingfan Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

libinyang · 2020-04-03T10:43:13Z

Runtime PM keeps active after boot up

There is ipc timed out message. (Clare will attach the dmesg in her new reported issue)

Call trace then System hang when start headset aplay/arecord or select Headphone as output source from sound setting

Clare will attach the dmesg in her new reported issue

MIC mute LED won’t light on, but mute/unmute control is working.

As thesofproject/sof#2358 has been merged, this can be easily fixed by adding :

CaptureSwitch "PGAx.0 x Master Capture Switch"
CaptureVolume "PGAx.0 x Master Capture Volume"

in the Mic "Value" section

Others issues which are related the mute/volume/switch can be easily fixed by a little modification in the UCM configuration.

@shumingfan

Use settings provided by @shumingfan Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

plbossart · 2020-04-03T16:04:46Z

sorry @libinyang @ClarexZhou my bad: I pushed the updated branch to the wrong tree :-(

See the update I did last week, works fine for me for speaker, headphone, dmic, headset on Olympic w/ latest firmware/kernel + Ubuntu 20.04

plbossart · 2020-04-08T16:40:41Z

merging to start handling fixes as pull requests

libinyang · 2020-04-21T11:01:33Z

ucm2/sof-soundwire/RT700.conf


 			EnableSequence [
-
+				cset "name='DAC Front Playback Volume' 87"


@plbossart speaker and headphone are using the same PCM. Do you know whether there is a kcontrol to control the sound come from, for example, mute headphone and unmute speaker?

You'd need to rely on the jack information and use priorities to switch from one to the other.

@plbossart Speaker and Headphone are using the same PCM. When we play with speaker, the headphone still have sound if we don't mute it. Jaroslav has a comment on RT700: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/854#note_471481. I think he is asking for this issue.

@plbossart I checked the SDW platforms with RT700, and there are "Headphones Switch" and "Speaker Switch". I think we can use them in the EnableSequence/DisableSequence. I will make a patch for it.

sof-soundwire: initial UCM2 version

a06d285

Add conditional inclusion of sections Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

libinyang reviewed Mar 18, 2020

View reviewed changes

This was referenced Mar 19, 2020

sof-sdw-rt711-1308-715: Speaker: merge L/R channels #31

Closed

SoundWire: transition to generic machine driver thesofproject/linux#1889

Merged

plbossart added 2 commits March 19, 2020 18:04

sof-soundwire: add RT700 and RT5682 initial support

5315b0f

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

sof-soundwire: add RT5682 settings

b41fb1c

Settings provided by M, Naveen <naveen.m@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

This was referenced Mar 20, 2020

[SDW][BUG]Output source in sound setting is wrong(shows:multichannel output ). thesofproject/linux#1918

Closed

[bug][SDW]Arecord0,1 by RT711 headset captured empty audio. thesofproject/linux#1919

Closed

RanderWang reviewed Mar 26, 2020

View reviewed changes

plbossart force-pushed the master branch from a5338fe to 4722f5b Compare March 27, 2020 19:22

plbossart added 2 commits March 27, 2020 14:40

sof-soundwire: align with PR#28

12ab70e

Apply the values suggested by Libin in PR#28 The split between profiles is not done, not sure why it was needed in the first place. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

sof-soundwire: update RT700 settings

8907bc4

Use settings provided by @shumingfan Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

ClarexZhou mentioned this pull request Apr 3, 2020

[BUG] [CML] IPC timed out for 0x60040000: GLB_STREAM_MSG: TRIG_START on ubuntu 20.04 thesofproject/sof#2703

Closed

ClarexZhou mentioned this pull request Apr 3, 2020

[Bug] [CML] Call Trace when using RT 711 headset playback/capture with UCM2 on ubuntu 20.04 thesofproject/linux#1979

Closed

sof-soundwire: update RT5682 settings

a363784

Use settings provided by @shumingfan Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

plbossart force-pushed the sof-soundwire branch from a045e1d to a363784 Compare April 3, 2020 16:03

YvonneYang2 mentioned this pull request Apr 8, 2020

[BUG][CML][SDW UCM2]Output source/input Device selection won't auto highlight on headphone/headset when plug in headset. thesofproject/linux#1999

Closed

plbossart merged commit bd7e4d6 into thesofproject:master Apr 8, 2020

libinyang reviewed Apr 21, 2020

View reviewed changes

Sof soundwire #29

Sof soundwire #29

Uh oh!

Conversation

plbossart commented Mar 16, 2020

Uh oh!

bardliao commented Mar 17, 2020

Uh oh!

plbossart commented Mar 17, 2020

Uh oh!

bardliao commented Mar 17, 2020

Uh oh!

plbossart commented Mar 17, 2020

Uh oh!

libinyang commented Mar 18, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

libinyang commented Mar 18, 2020

Uh oh!

bardliao commented Mar 18, 2020

Uh oh!

libinyang commented Mar 18, 2020

Uh oh!

libinyang commented Mar 18, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ClarexZhou commented Mar 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanderWang Mar 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RanderWang commented Mar 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

libinyang commented Mar 26, 2020

Uh oh!

libinyang commented Apr 3, 2020

Uh oh!

plbossart commented Apr 3, 2020

Uh oh!

plbossart commented Apr 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ClarexZhou commented Mar 26, 2020 •

edited

Loading

RanderWang Mar 26, 2020 •

edited

Loading

RanderWang commented Mar 26, 2020 •

edited

Loading