Skip to content

ext_manifest: clean up IPC extended data and handle PROBE_INFO #2491

@fredoh9

Description

@fredoh9

While discussing on
#2297

  1. After merging/enabling Extended Manifest, IPC extended data from FW_READY will be obsolete. Need to clean up snd_sof_fw_parse_ext_data() from FW_READY.

  2. Need to use Explicit numbers in below sof_ext_man_elem_type

/* Extended manifest elements types */
enum sof_ext_man_elem_type {
	SOF_EXT_MAN_ELEM_FW_VERSION		= 0,
	SOF_EXT_MAN_ELEM_WINDOW			= SOF_IPC_EXT_WINDOW,
	SOF_EXT_MAN_ELEM_CC_VERSION		= SOF_IPC_EXT_CC_INFO,
	SOF_EXT_MAN_ELEM_DBG_ABI		= SOF_IPC_EXT_USER_ABI_INFO,
	SOF_EXT_MAN_ELEM_CONFIG_DATA		= 5,
	SOF_EXT_MAN_ELEM_PLATFORM_CONFIG_DATA   = 6,
};
  1. Define SOF_EXT_MAN_ELEM_PROBE_INFO(=3) and handle it. Need to look at PROBE_INFO structure. Either use or ignore it to avoid unknown header type.
[    1.564098] sof-audio-pci 0000:00:1f.3: found sof_ext_man header type 3 size 0x30
[    1.564099] sof-audio-pci 0000:00:1f.3: warning: unknown sof_ext_man header type 3 size 0x30

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions