forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 140
ASoC: SOF: ext_manifest: use explicit number for elem_type #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kv2019i
merged 1 commit into
thesofproject:topic/sof-dev
from
fredoh9:fix/clean_config_data
Nov 24, 2020
Merged
ASoC: SOF: ext_manifest: use explicit number for elem_type #2553
kv2019i
merged 1 commit into
thesofproject:topic/sof-dev
from
fredoh9:fix/clean_config_data
Nov 24, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktrzcinx
reviewed
Nov 6, 2020
lyakh
requested changes
Nov 9, 2020
Collaborator
Author
|
I checked with SOF FW v1.6 and v1.5.1. |
Use explicit number to define elem_type eunm instead of using SOF_IPC_EXT_*. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
bf4b822 to
763f291
Compare
Collaborator
Author
|
I dropped cleaning up extended data after fw_ready because it breaks backward compatibility. But setting explicit numbers for ext manifest enum is good to go. |
lyakh
approved these changes
Nov 17, 2020
ktrzcinx
approved these changes
Nov 17, 2020
kv2019i
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend manifest replace extended FW boot data(in fw_ready section). This is obsolete from SOF firmware.
Fixes : #2491