Skip to content

Conversation

@xiulipan
Copy link

Add enumerations to support smart amp and smart amp demux processing
component.

Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com

Add enumerations to support smart amp and smart amp demux processing
component.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@singalsu
Copy link

Could the smart amp demux be called just demux or make existing demux capable enough to support smart amp needs? Is there something that makes it special for smart amps only?

@juimonen
Copy link

@xiulipan I guess you should add the token parsing also, @bkokoszx same thing topology changes for fw side should be visible...

@juimonen
Copy link

but yeah if there are not tokens, then no parsing needed :)

@plbossart
Copy link
Member

agree with @singalsu what is so special about the demux here?

@bkokoszx
Copy link

@plbossart @singalsu
I've decided to create separate component type for smart amp demux, because it could have some specific algorithm splitting captured stream (from DAI) into feedback stream (stream going back to smart amp component) and host stream (as it is illustrated in thesofproject/sof#1896 (comment)). As I understand, simple DEMUX just copies input to outputs - it does not have any additional processing.

@plbossart
Copy link
Member

@plbossart @singalsu
I've decided to create separate component type for smart amp demux, because it could have some specific algorithm splitting captured stream (from DAI) into feedback stream (stream going back to smart amp component) and host stream (as it is illustrated in thesofproject/sof#1896 (comment)). As I understand, simple DEMUX just copies input to outputs - it does not have any additional processing.

what algorithms? if there are algorithms to combine multiple channels, they should be in the smart amp component, I don't get how you would require the processing to be split in two components, with potentially the risk of channel combination being misaligned with what the smart amp processing assumes or does.

@xiulipan xiulipan changed the title ASoC: SOF: topology: add support for smart amp component [RFC]ASoC: SOF: topology: add support for smart amp component Oct 22, 2019
@xiulipan
Copy link
Author

@plbossart @bkokoszx @singalsu Sorry to forget the [RFC] tag.

@bkokoszx said we will need no other tokens. So no new parse is needed.
I am working on the tplg patch too. Need to clarify if we need two components.

@plbossart Do we need a ABI for change like this?

@plbossart plbossart added the Unclear No agreement on problem statement and resolution label Oct 22, 2019
@plbossart
Copy link
Member

moving this PR to the 'Unclear' bucket since I just don't understand the directions

@lbetlej you may want to chime in on why we need a different demux?

@plbossart
Copy link
Member

closing since there's been no activity in 27 days.

@plbossart plbossart closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unclear No agreement on problem statement and resolution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants