Skip to content

Conversation

@xiulipan
Copy link
Contributor

Add smart amp topology macro and an example tplg for
apl pcm512x.

# PCM0 --> buf --> volume --> Smart AMP --> buf --> SSP5 (pcm512x)
#                                ^
#                                |
#                               buf
#                                ^
#                                |
# PCM0 <-- buf <-- volume <-- Smart AMP --< buf <-- SSP5 (pcm512x)

Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com

@xiulipan
Copy link
Contributor Author

@bkokoszx Add a volume comp in the pipeline. Not sure if this is the right way to make the pipeline.
Could you share more detail about how the smart amp is used?

@xiulipan xiulipan changed the title topology: add smart amp for apl pcm512x [RFC]topology: add smart amp for apl pcm512x Oct 22, 2019
@bkokoszx
Copy link
Collaborator

@xiulipan
As I wrote here
#1896 (comment)
there should be no problems with using volume component. Could you share the whole log from tests?

Add smart amp topology macro and an example tplg for
apl pcm512x.
only s16le/s32le format is support for amp now.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan do we need any tokens or ABI update ?

@xiulipan
Copy link
Contributor Author

xiulipan commented Nov 5, 2019

@lgirdwood From @bkokoszx and the test result the only token we add was one more string value for SOF_TKN_PROCESS_TYPE . And we will need some parse thesofproject/linux#1343 in Kernel to handle it.
It may be some minor ABI change at most.

@lgirdwood lgirdwood added the ABI ABI change involved label Nov 5, 2019
@lgirdwood
Copy link
Member

@xiulipan ABI labels added, please assign ABI minor to align with kernel.

@zrombel
Copy link

zrombel commented Nov 27, 2019

Due to PR#2029 merge and CI bit depth conversion tests changes - this PR require rebase.

@lgirdwood lgirdwood added this to the ABI-3.17 milestone Jun 12, 2020
@lgirdwood
Copy link
Member

@xiulipan ping ?

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 4, 2020

@xiulipan ping?

@lgirdwood
Copy link
Member

@xiulipan moving to v1.7 and ABI 3.18

@lgirdwood lgirdwood modified the milestones: ABI-3.17, ABI-3.18 Sep 17, 2020
@xiulipan
Copy link
Contributor Author

@lgirdwood Close this as we already have smart amp support and test topology,

@xiulipan xiulipan closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI ABI change involved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants