-
Notifications
You must be signed in to change notification settings - Fork 140
ASoC: SOF: intel: lower print level to dbg if we will reinit DSP #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASoC: SOF: intel: lower print level to dbg if we will reinit DSP #1676
Conversation
|
@Bin-QA I didn't touch the error message in hda_init_caps() and hda_dsp_dump() since the error message there could be a real error. |
|
@bardliao I think we can lower the level to dev_dbg. What do you think? |
I'd argue dev_warn is correct unless it's typical to do such reloads, and dropping it below dev_info isn't that good of an option unless it happens very often. |
We will reinit DSP when it is fail to init. So, it is not an error before we finally give up. And reorder the trace to make it more readable. Signed-off-by: Bard liao <yung-chuan.liao@linux.intel.com>
|
I'd also move to dev_dbg. There are known cases where we need extra time, and we should only report those retries for debug cases, the average users should not know or care. |
|
I can understand this change, but from error message, So your patch just fix line 3 & line 4 output in |
f38c1e9 to
dc3a12c
Compare
|
Update the PR with dev_dbg |
@Bin-QA I agree that the patch won't fix the CI issue. My point is that the trace will let us know there is something wrong on cl_dsp_init(). Although we will retry it, but we do fail to cl_dsp_init(). It seems to be overkilled if we remove the error message from cl_dsp_init(). |
@bardliao So you suggest CI catch this type error to report the warning/add this into ignore list |
|
For my understanding: do we know what causes such soft initialisation failures, that can be eliminated by re-trying? |
Yeah, I can see initialization failure in system suspend/resume and success at the second try. |
In my opinion, It would be better if CI can know if the error could be fixed by retry rather than ignore it without any condition. |
After patch: thesofproject/linux#1676 merged add "error: status" and "error: cl_dsp_init" into ignore string to avoid catch DPS reset which can be ignored Signed-off-by: Wu, BinX <binx.wu@intel.com>
After patch: thesofproject/linux#1676 merged add "error: status" and "error: cl_dsp_init" into ignore string to avoid catch DPS reset which can be ignored Signed-off-by: Wu, BinX <binx.wu@intel.com>
|
Please review thesofproject/sof-test#395 which ignores this error message - again after @plbossart removed the filter. |
We will reinit DSP when it is fail to init. So, it is not an error before
we finally give up. And reorder the trace to make it more readable.
Signed-off-by: Bard liao yung-chuan.liao@linux.intel.com