Skip to content

Conversation

@bardliao
Copy link
Collaborator

@bardliao bardliao commented Jan 9, 2020

We will reinit DSP when it is fail to init. So, it is not an error before
we finally give up. And reorder the trace to make it more readable.

Signed-off-by: Bard liao yung-chuan.liao@linux.intel.com

@bardliao
Copy link
Collaborator Author

bardliao commented Jan 9, 2020

@Bin-QA I didn't touch the error message in hda_init_caps() and hda_dsp_dump() since the error message there could be a real error.

paulstelian97
paulstelian97 previously approved these changes Jan 9, 2020
@dbaluta
Copy link
Collaborator

dbaluta commented Jan 9, 2020

@bardliao I think we can lower the level to dev_dbg. What do you think?

@paulstelian97
Copy link

@bardliao I think we can lower the level to dev_dbg. What do you think?

I'd argue dev_warn is correct unless it's typical to do such reloads, and dropping it below dev_info isn't that good of an option unless it happens very often.

We will reinit DSP when it is fail to init. So, it is not an error before
we finally give up. And reorder the trace to make it more readable.

Signed-off-by: Bard liao <yung-chuan.liao@linux.intel.com>
@plbossart
Copy link
Member

I'd also move to dev_dbg. There are known cases where we need extra time, and we should only report those retries for debug cases, the average users should not know or care.

@Bin-QA
Copy link

Bin-QA commented Jan 10, 2020

I can understand this change, but from error message,
it dump for the 4 error line: which refer this change:
like:

kernel: [  604.503173] sof-audio-pci 0000:00:1f.3: error: cl_dsp_init: timeout HDA_DSP_SRAM_REG_ROM_STATUS read
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503206] sof-audio-pci 0000:00:1f.3: error: status = 0x00000000 panic = 0x00000000
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503258] sof-audio-pci 0000:00:1f.3: error: Error code=0xffffffff: FW status=0xffffffff
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503261] sof-audio-pci 0000:00:1f.3: error: iteration 0 of Core En/ROM load failed: -110

So your patch just fix line 3 & line 4 output in dmesg, how about line 1 & line 2
From CI/automation, we will catch for sof-audio-pci + error as keyword

@bardliao bardliao changed the title ASoC: SOF: intel: show warning instead of error if we will reinit DSP ASoC: SOF: intel: lower print level to dbg if we will reinit DSP Jan 10, 2020
@bardliao
Copy link
Collaborator Author

Update the PR with dev_dbg

@bardliao
Copy link
Collaborator Author

I can understand this change, but from error message,
it dump for the 4 error line: which refer this change:
like:

kernel: [  604.503173] sof-audio-pci 0000:00:1f.3: error: cl_dsp_init: timeout HDA_DSP_SRAM_REG_ROM_STATUS read
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503206] sof-audio-pci 0000:00:1f.3: error: status = 0x00000000 panic = 0x00000000
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503258] sof-audio-pci 0000:00:1f.3: error: Error code=0xffffffff: FW status=0xffffffff
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503261] sof-audio-pci 0000:00:1f.3: error: iteration 0 of Core En/ROM load failed: -110

So your patch just fix line 3 & line 4 output in dmesg, how about line 1 & line 2
From CI/automation, we will catch for sof-audio-pci + error as keyword

@Bin-QA I agree that the patch won't fix the CI issue. My point is that the trace will let us know there is something wrong on cl_dsp_init(). Although we will retry it, but we do fail to cl_dsp_init(). It seems to be overkilled if we remove the error message from cl_dsp_init().

kernel: [  604.503173] sof-audio-pci 0000:00:1f.3: error: cl_dsp_init: timeout HDA_DSP_SRAM_REG_ROM_STATUS read
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503206] sof-audio-pci 0000:00:1f.3: error: status = 0x00000000 panic = 0x00000000

@Bin-QA
Copy link

Bin-QA commented Jan 10, 2020

@Bin-QA I agree that the patch won't fix the CI issue. My point is that the trace will let us know there is something wrong on cl_dsp_init(). Although we will retry it, but we do fail to cl_dsp_init(). It seems to be overkilled if we remove the error message from cl_dsp_init().

kernel: [  604.503173] sof-audio-pci 0000:00:1f.3: error: cl_dsp_init: timeout HDA_DSP_SRAM_REG_ROM_STATUS read
Dec 24 15:20:52 jf-icl-rvp-hda-4 kernel: [  604.503206] sof-audio-pci 0000:00:1f.3: error: status = 0x00000000 panic = 0x00000000

@bardliao So you suggest CI catch this type error to report the warning/add this into ignore list

@lyakh
Copy link
Collaborator

lyakh commented Jan 10, 2020

For my understanding: do we know what causes such soft initialisation failures, that can be eliminated by re-trying?

@bardliao
Copy link
Collaborator Author

For my understanding: do we know what causes such soft initialisation failures, that can be eliminated by re-trying?

Yeah, I can see initialization failure in system suspend/resume and success at the second try.

@bardliao
Copy link
Collaborator Author

@bardliao So you suggest CI catch this type error to report the warning/add this into ignore list

In my opinion, It would be better if CI can know if the error could be fixed by retry rather than ignore it without any condition.

@plbossart plbossart merged commit efb8cfc into thesofproject:topic/sof-dev Jan 10, 2020
Bin-QA added a commit to Bin-QA/sof-test that referenced this pull request Jan 14, 2020
After patch: thesofproject/linux#1676 merged
add "error: status" and "error: cl_dsp_init" into ignore string
to avoid catch DPS reset which can be ignored

Signed-off-by: Wu, BinX <binx.wu@intel.com>
xiulipan pushed a commit to thesofproject/sof-test that referenced this pull request Jan 15, 2020
After patch: thesofproject/linux#1676 merged
add "error: status" and "error: cl_dsp_init" into ignore string
to avoid catch DPS reset which can be ignored

Signed-off-by: Wu, BinX <binx.wu@intel.com>
@marc-hb
Copy link
Collaborator

marc-hb commented Sep 22, 2020

Please review thesofproject/sof-test#395 which ignores this error message - again after @plbossart removed the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants