Add old ignore pattern for sof-kernel-log-check #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Two suggestions:
|
Revert "sof-kernel-log-check: remove filter on initial boot issues" This reverts commit 8797c85. We can still see such issues on old kernels eg. 5.8.10 Need to ignore this in our test for old kernels. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
xiulipan
force-pushed
the
pr/getolddmesg
branch
from
31b0744 to
c079757
Compare
Contributor
Author
|
@marc-hb Updated. please review |
marc-hb
approved these changes
Sep 23, 2020
lyakh
reviewed
Sep 23, 2020
| # Check https://github.com/thesofproject/linux/pull/1676 for more information. | ||
| # Fixed by https://github.com/thesofproject/linux/pull/2382 | ||
| ignore_str="$ignore_str"'|error: iteration [01]' | ||
| ignore_str="$ignore_str"'|error: status' |
Contributor
There was a problem hiding this comment.
Does this mean that all error messages, containing the "error: status" substring will be ignored? That would seem overly broad to me.
Collaborator
There was a problem hiding this comment.
Thanks @lyakh for paying close attention. I think you're right BUT |error: status will be practically ignored only if it's alone or only with other lines ignored too. If at least one error line is not ignored then you get access to the entire kernel log for the corresponding test, @xiulipan confirm?
Contributor
Author
There was a problem hiding this comment.
Yes, I think other real errors will still be caught.
marc-hb
added
the
area:non-audio Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For old kernels like 5.8.10, we can still get boot fail logs in old style.
Add them into ignore list in sof-kernel-log-check