Skip to content

ignore_str filter updates from Pierre #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiulipan merged 4 commits into from
Sep 8, 2020
Merged

ignore_str filter updates from Pierre #362

xiulipan merged 4 commits into from
Sep 8, 2020

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Sep 3, 2020

Re-submitting the first part of #354 . This only updates the ignore_str filters and does not have any actual code change.

@plbossart @marc-hb
sof-kernel-log-check: remove filter on initial boot issues
c108144 
The kernel was modified to only throw errors after the last boot
attempt, there should be no need to filter in sof-test.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart @marc-hb
sof-kernel-log-check.sh: remove Realtek parity filter
3720127 
This error is now handled in the topic/sof-dev kernel.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart @marc-hb
sof-kernel-log-check.sh: add Dell CML-U w/ SoundWire filters
5d9e618 
TPM, iwlwifi and thermal zone warnings

All warnings are checked with '.', '(' and ')' treated as escapes to
avoid regexp issues.

BugLink: thesofproject#307
BugLink: thesofproject#343
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart @marc-hb
sof-kernel-log-check.sh: handle escape characters
6579565 
'.' is a special character in a regexp.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 3, 2020 •
edited
Loading

The shellcheck warnings all predate this PR.

Summary of https://sof-ci.01.org/softestpr/PR362/build150/devicetest/

  • The only "real" failures are caused by this ICL fw reboot issue:
kernel: [  486.166822] sof-audio-pci 0000:00:1f.3: status = 0x00000000 panic = 0x00000000
  • All the other issues are SKIPs (or SKIPs under a different name like "Not Applicable"), except for:
  • One CML device was not available.

As this PR performs a number of CML-related changes, I consider it ready for review but not for merge yet.

@marc-hb marc-hb marked this pull request as ready for review September 3, 2020 23:41
@marc-hb marc-hb requested a review from a team as a code owner September 3, 2020 23:41
@marc-hb marc-hb mentioned this pull request Sep 3, 2020
Closed
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 4, 2020

SOFCI TEST

This was referenced Sep 4, 2020
Closed
Merged
@marc-hb marc-hb requested review from bardliao and kv2019i September 4, 2020 17:44
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 4, 2020

The CML situation just got worse today: all CML tests fail with File /lib/firmware/intel/sof/sof-cml.ri is not found! (or sof-cnl.ri not found for CML_MANTIS_HDA.

This is of course not specific to this PR, here are some other random examples:
https://sof-ci.01.org/sofpr/PR3389/build7120/devicetest/
https://sof-ci.01.org/linuxpr/PR2422/build4438/devicetest/

This started happening across all git repos and all CML devices in the last 12 hours.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 4, 2020

SOFCI TEST

@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 4, 2020

This started happening across all git repos and all CML devices in the last 12 hours.

Root caused by @fredoh9 to an internal script change merged 11 hours ago and fixed by @fredoh9 just now.

All CML devices look fine now in https://sof-ci.01.org/softestpr/PR362/build152/devicetest, I think this is merge-ready (remember it was already reviewed in #354)

xiulipan
xiulipan approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@xiulipan xiulipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this seems ignore most new error logs from our test.

@xiulipan xiulipan merged commit a5f0cfc into thesofproject:master Sep 8, 2020
@marc-hb marc-hb mentioned this pull request Sep 9, 2020
Closed
@marc-hb marc-hb deleted the ignore-cleanup branch September 23, 2020 00:58
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 23, 2020

Removal of some exclusions partially reverted in #395 to support testing with older kernels.

Simplifying the triple negation: need to ignore some errors again to support testing with older kernels.

@xiulipan xiulipan mentioned this pull request Sep 24, 2020
Closed
@marc-hb marc-hb added the area:non-audio Failure False positives: failing when we don't want to label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bardliao bardliao Awaiting requested review from bardliao

@kv2019i kv2019i Awaiting requested review from kv2019i

1 more reviewer

@xiulipan xiulipan xiulipan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:non-audio Failure False positives: failing when we don't want to

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-hb @xiulipan @plbossart