tools: update the checklist and ignore list with boot time #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With thesofproject/linux#2382 no error logs will generate in boot time. Udpate the err list and ignore list with this update. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
lyakh
reviewed
Aug 28, 2020
Contributor
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
you removed "panic" because it also triggers a different keyword, maybe "error"?
Member
we need to keep panic, but only when it's a dev_err/warn level. We have a couple of dev_dbg() logs which use 'panic', but they are harmless. |
Member
|
yes this seems redundant with #354, let's close this one. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With thesofproject/linux#2382
no error logs will generate in boot time. Udpate the err list
and ignore list with this update.
Fix #340
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com